debug irmi #42
Merged
debug irmi #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use lower_camel_case for all internal variables in R/irmi.R. Leave exposed variables (i.e. function parameters) the same.
|
@alexkowa could you please take a look at 480dda8 and tell me if this makes sense from a methodological standpoint?
Maybe it would make more sense to treat them as factors under both circumstances. |
- avoid assigning variables in if-else blocks - enable logicals for noise calculation (L476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #16 and #17 by investigating the behavior of
irmi()with unexpected/untested vector types