-
Notifications
You must be signed in to change notification settings - Fork 4
fix(StatusPopupMenu)!: Refactoring #894
base: fix/status-menu
Are you sure you want to change the base?
Conversation
733d571
to
7c24ea3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave it a quick glance. There's a bunch of comments left in the code base.
Is this a WIP?
Also, this needs to be tested a lot also inside desktop as these changes are pretty invasive.
Would it be possible otherwise, to break this up in to smaller pieces?
Say, first make StatusMenuItem
a StatusAction
, then get those changes into Status Desktop, then make StatusPopupMenu
a StatusMenu
etc?
It's just one of those breaking changes that will shoot us massively in the foot.
Another proposal: Introduce StatusAction
, ... etc in addition to the existing compnents, then replace legacy components in desktop, then get rid of legacy components in StatusQ
@PascalPrecht, actually I am making the changes partially - this is a PR to About partial changes file-by-file: it's also not possible, because there are property interdependencies, which are removed. I thought about making a "temporary-naming" transition, It's not possible cause we rename current Sorry, I will remove the comments. |
637a068
to
5486b27
Compare
@igor-sirotin looks like a rebase gone wrong... all the chart stuff and extra commits in this PR :) |
…nships Comments removed
5486b27
to
49c58f4
Compare
@caybro that was strange! Fixed now 👌 |
This PR is for status-im/status-desktop#7232
All Menu components are refactored.
Some UI improvements made:
status-desktop
StatusPopupMenu
StatusMenu
StatusMenuItem
StatusAction
StatusMenuItemDelegate
StatusMenuItem
Checklist
feat(StatusListItem): ...
feat(StatusQ.Controls): ...
BREAKING CHANGE
commit message section