Rejected identity verification request is displayed as pending on user's profile

[Michal-Status]

Bug Report

Description

When a identity verification request is rejected by the recipient, the contact request is still displayed as pending when looking at their profile. In the notification tab it's displayed as rejected. This makes it impossible to send a new verification request to that same contact, because it makes it impossible to cancel a request in that case. Cancelling a request that has not been rejected works as intended.

Steps to reproduce

1. Send a contact request and accept
2. Send a ID request to the contact
3. Recipient of ID request refuses
4. ID request is shown as refused in activity centre

Expected behavior

• ID request is not shown as pending in profile menu
• Cancel button cancels ID request
• ID request shouldn't be displayed as pending when it has been rejected?

Actual behavior

• ID request is shown as pending in profile menu
• Cancel button does not cancel the ID request

Additional Information

• Status desktop version: Can be found here: https://ci.status.im/job/status-desktop/job/systems/job/macos/job/aarch64/job/package/284/
• Operating System: macOS

Screen.Recording.2024-02-02.at.18.02.33.mov

Console log of cancel button not working:

ERR 2024-02-02 16:32:15.777+00:00 rpc response error                         topics="rpc" tid=27204477 file=core.nim:36 err="\nstatus-go error [methodName:wakuext_cancelVerificationRequest, code:-32000, message:can cancel only pending verification request ]\n"
ERR 2024-02-02 16:32:15.777+00:00 error doing rpc request                    topics="rpc" tid=27204477 file=core.nim:40 methodName=wakuext_cancelVerificationRequest exception="\nstatus-go error [methodName:wakuext_cancelVerificationRequest, code:-32000, message:can cancel only pending verification request ]\n"
ERR 2024-02-02 16:32:15.777+00:00 Error canceling verification request       topics="contacts-service" tid=27204477 file=service.nim:754 msg="\nstatus-go error [methodName:wakuext_cancelVerificationRequest, code:-32000, message:can cancel only pending verification request ]\n""

[anastasiyaig]

@iurimatias ^

[jrainville]

I think the expected behaviour here is that whoever one of the parties cancels the verification, it goes back to the basic state of just being mutual contact. So both of them can then reinitiate the ID verification from scratch. The AC notifi saying canceled is fine, but the profile shouldn't show anything. As seen here:

• Canceled by receiver: https://www.figma.com/file/ibJOTPlNtIxESwS96vJb06/%F0%9F%91%A4-Profile-%7C-Desktop?type=design&node-id=2460-205285&mode=design&t=ONGZWWw4TeiJa0Fw-0
• Canceled by sender: https://www.figma.com/file/ibJOTPlNtIxESwS96vJb06/%F0%9F%91%A4-Profile-%7C-Desktop?type=design&node-id=2460-203422&mode=design&t=ONGZWWw4TeiJa0Fw-0

[Michal-Status]

Issue does not occur on https://ci.infra.status.im/job/status-desktop/job/release/job/release%2F2.27.x/14/ build