Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an user responds to contact request with "Decline and block", the sender of the CR receives a notification that they have been removed from contacts #13545

Closed
Michal-Status opened this issue Feb 13, 2024 · 2 comments · Fixed by status-im/status-go#4799
Closed

When an user responds to contact request with "Decline and block", the sender of the CR receives a notification that they have been removed from contacts #13545

Michal-Status opened this issue Feb 13, 2024 · 2 comments · Fixed by status-im/status-go#4799
Assignees
@jrainville
Labels
bug Something isn't working E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests
Milestone
2.28.0 Beta

Comments

@Michal-Status
Copy link

Bug Report

Description

The user that sent the contact request that has been declined with a block receives a notification that they have been removed from contacts, despite not being a contact of the other user. This causes an issue, because this tells the user that they have been blocked.

Steps to reproduce

  1. Log into two accounts that don't have each other in contacts
  2. Send a contact request from User1 to User2
  3. As User2 use activity center to decline the contact request

Expected behavior

From the point of view of User1 the notifications for "Decline and block" should be the same as for a normal rejection without a block

Actual behavior

The user that sent the contact request that has been declined with a block receives a notification that they have been removed from contacts, despite not being a contact of the other user

Additional Information

Notification after the request has been rejected:
Screenshot_2024-02-13_at_13 08 41

Notification after the request has been declined with a block:
Screenshot_2024-02-13_at_13 11 25
@Michal-Status Michal-Status added the bug Something isn't working label Feb 13, 2024
@anastasiyaig anastasiyaig added messenger-team E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests labels Feb 13, 2024
@anastasiyaig
Copy link
Contributor

@jrainville i think we dont really have to send this notification (if that's possible ofc) wdyt?

@Michal-Status Michal-Status changed the title When a user responds to contact request with "Decline and block", the sender of the CR receives a notification that they have been removed from contacts When an user responds to contact request with "Decline and block", the sender of the CR receives a notification that they have been removed from contacts Feb 13, 2024
@jrainville
Copy link
Member

@jrainville i think we dont really have to send this notification (if that's possible ofc) wdyt?

Yes you're right. We should do the same as a normal rejection, ie not tell the other user that we rejected. They shouldn't know that we responded, even less blocked them.

@jrainville jrainville added this to the 2.28.0 Beta milestone Feb 13, 2024
@anastasiyaig anastasiyaig mentioned this issue Feb 14, 2024
Closed
@jrainville jrainville self-assigned this Feb 22, 2024
jrainville added a commit to status-im/status-go that referenced this issue Feb 22, 2024
@jrainville
fix(contacts): fix blocking a non-contact sends a signal to the other
c0cdd69 
Fixes status-im/status-desktop#13545

The code is correct in sending an updated CR to make sure the sync doesn't sync back the previous state or at least overrides it.
However, if we never were a contact with the person sending us a CR, and we block them, it sends them a "you got removed" message, which first doesn't make sense but also could let them know they got blocked/ignored.
The trick is just to make sure we added them first. Then dismissing the CR makes sense.
@jrainville jrainville mentioned this issue Feb 22, 2024
Merged
jrainville added a commit to status-im/status-go that referenced this issue Feb 23, 2024
@jrainville
fix(contacts): fix blocking a non-contact sends a signal to the other
31e410d 
Fixes status-im/status-desktop#13545

The code is correct in sending an updated CR to make sure the sync doesn't sync back the previous state or at least overrides it.
However, if we never were a contact with the person sending us a CR, and we block them, it sends them a "you got removed" message, which first doesn't make sense but also could let them know they got blocked/ignored.
The trick is just to make sure we added them first. Then dismissing the CR makes sense.
jrainville added a commit to status-im/status-go that referenced this issue Feb 26, 2024
@jrainville
fix(contacts): fix blocking a non-contact sends a signal to the other (…
2445cda 
…#4799)

Fixes status-im/status-desktop#13545

The code is correct in sending an updated CR to make sure the sync doesn't sync back the previous state or at least overrides it.
However, if we never were a contact with the person sending us a CR, and we block them, it sends them a "you got removed" message, which first doesn't make sense but also could let them know they got blocked/ignored.
The trick is just to make sure we added them first. Then dismissing the CR makes sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
bug Something isn't working E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.28.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(contacts): fix blocking a non-contact sends a signal to the other status-im/status-go
3 participants
@jrainville @anastasiyaig @Michal-Status