Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI - Wallet Stability] Ensure / review all the entry points for Send #15217

Closed
Tracked by #14711
noeliaSD opened this issue Jun 17, 2024 · 8 comments · Fixed by #15648
Closed
Tracked by #14711

[UI - Wallet Stability] Ensure / review all the entry points for Send #15217

noeliaSD opened this issue Jun 17, 2024 · 8 comments · Fixed by #15648
Assignees
Labels
blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor
Milestone

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024

Ensure all the User Stories and details defined in here are covered and working as expected:

@noeliaSD noeliaSD changed the title [UI - Wallet Stability] Ensure / review all the entry points for bothSend [UI - Wallet Stability] Ensure / review all the entry points for Send Jun 17, 2024
@noeliaSD noeliaSD added ui-team refactor blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality labels Jun 17, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone Jun 17, 2024
@noeliaSD
Copy link
Contributor Author

It would make sense to work on it together with #15215

@noeliaSD
Copy link
Contributor Author

noeliaSD commented Jul 3, 2024

Ensure we are also covering this use case #15567 (comment) here. It's part of one of the user stories, but I link the comment as a reminder!

@noeliaSD noeliaSD assigned noeliaSD and alexjba and unassigned micieslak and noeliaSD Jul 12, 2024
@alexjba
Copy link
Contributor

alexjba commented Jul 16, 2024

General rules

  • Preselecting the assets or collectible in the send modal:
    1. When send modal is opened in the context of an asset or collectible (context menu, token details)
  • Preselecting the account:
    1. When the send modal is opened in the account context, that account is preselected
    2. When the send modal is opened in the context of all accounts the first account in the sorted account list is preselected

TO-DO Send Modal

  • ALL TABS - FOOTER: Add footer button when all accounts is selected
  • COLLECTIBLES - MENU - Don't show the send button in context menu for the collectibles not owned in any user account (https://www.notion.so/From-Main-Wallet-View-Context-menu-ff2c779b113e4243b5364c465188ea3a?pvs=4#bef0d8e5e434444e9b8ffaf53c5b86a8)
  • COLLECTIBLES - MENU: When opening the send modal from collectibles context menu we should preselect the collectible and the collectible account
  • ASSETS - MENU - When opening the send modal from assets context menu we should preselect the account based on general rules and the asset
  • Disable Send context menu for assets and accounts not owned by the user or not transferable.
  • TOKEN DETAILS : Preselect the account and token when send modal is opened from Token details view.
  • ACTIVITY VIEW: Add Repeat transaction context menu button on Sent transactions in the activity view. Clicking this opens the send modal with all the data preselected to repeat the transaction (from, to, amount, token)
  • TRANSFER OWNERSHIP: Preselect the account and token

@alexjba
Copy link
Contributor

alexjba commented Jul 16, 2024

CHORES:

  • Fix crash when activating the send modal from All accounts footer option
  • Fix the default account selection when the first account in the list is a watch-only account
  • Check community tokens in the wrong category. See video below
  • Fix the Send button text in the footer when the community owner tokens is selected in the collectible details view. It's always showing the communityId
  • Update Notion user stories based on the agreed behaviour described in the previous comment
Screen.Recording.2024-07-17.at.11.40.37.mov

@alexjba
Copy link
Contributor

alexjba commented Jul 17, 2024

Notes for QA team: Please test/add squish tests for the default account selection in Send, Bridge, Swap, Receive and DApp when we have a watch-only account defined as the first account in the account order settings.
Currently the default account selection is broken in this flow. Will be fixed as part of this task.

cc @anastasiyaig

@anastasiyaig
Copy link
Contributor

@Valentina1133 pls work on that as next item

@alexjba
Copy link
Contributor

alexjba commented Jul 17, 2024

For reference, this is from the latest master:

Screen.Recording.2024-07-17.at.11.38.28.mov

@Valentina1133

@Valentina1133
Copy link
Contributor

For reference, this is from the latest master:

Screen.Recording.2024-07-17.at.11.38.28.mov

@Valentina1133

Ok. Got it. Will be covered, created a task for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants