Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI - Wallet Stability] Review Selected Recipient section from SendModal and create new / update component that contains the needed logic from TabAddressSelectorView #15208

Closed
Tracked by #14711
noeliaSD opened this issue Jun 17, 2024 · 0 comments · Fixed by #15470
Closed
Tracked by #14711

[UI - Wallet Stability] Review Selected Recipient section from SendModal and create new / update component that contains the needed logic from TabAddressSelectorView #15208

noeliaSD opened this issue Jun 17, 2024 · 0 comments · Fixed by #15470
Assignees
@noeliaSD
Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor
Milestone
2.30.0 Beta

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024 •
edited
Loading

Design

Screenshot 2024-06-17 at 15 16 25

  • It seems that RecipientView contains some logic not used bc it's already defined and used via TabAddressSelectorView
  • It would be ideal to split each tab in diferent components where only basic list views are defined with their specific models, excluding dependencies of stores:
    • Saved addresses list view
    • My Accunts list view
    • Recent list view
    • Contacts list view
  • To input is not part of this scope. It will be worked in: [UI - Wallet Stability] Review all To input usecases of SendModal  #15252
@noeliaSD noeliaSD mentioned this issue Jun 17, 2024
Closed
12 tasks
@noeliaSD noeliaSD added ui-team refactor E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality labels Jun 17, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone Jun 17, 2024
@noeliaSD noeliaSD changed the title Review Selected Recipient section from SendModal and create new component that contains the needed logic from RecipientView and TabAddressSelectorView [UI - Wallet Stability] Review Selected Recipient section from SendModal and create new component that contains the needed logic from RecipientView and TabAddressSelectorView Jun 17, 2024
@noeliaSD noeliaSD mentioned this issue Jun 17, 2024
Closed
9 tasks
@noeliaSD noeliaSD assigned noeliaSD and unassigned micieslak Jun 21, 2024
@noeliaSD noeliaSD changed the title [UI - Wallet Stability] Review Selected Recipient section from SendModal and create new component that contains the needed logic from RecipientView and TabAddressSelectorView [UI - Wallet Stability] Review Selected Recipient section from SendModal and create new / update component that contains the needed logic from TabAddressSelectorView Jul 2, 2024
noeliaSD added a commit that referenced this issue Jul 5, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
6ac4a89 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
@noeliaSD noeliaSD mentioned this issue Jul 5, 2024
Merged
2 tasks
noeliaSD added a commit that referenced this issue Jul 8, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
23efdc8 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
noeliaSD added a commit that referenced this issue Jul 9, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
97cbb2e 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
noeliaSD added a commit that referenced this issue Jul 9, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
04a19d5 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
noeliaSD added a commit that referenced this issue Jul 10, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
5169a67 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
noeliaSD added a commit that referenced this issue Jul 11, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
365ddad 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
noeliaSD added a commit that referenced this issue Jul 11, 2024
@noeliaSD
refactor(Wallet/SendModal): Selected Recipients component review, bac…
18e230b 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
alexjba pushed a commit that referenced this issue Jul 11, 2024
@noeliaSD @alexjba
refactor(Wallet/SendModal): Selected Recipients component review, bac…
c1a7485 
…kend dependencies cleanup

- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noeliaSD noeliaSD

Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0 Beta
2 participants
@micieslak @noeliaSD