chore(wallet) add pending transaction test helpers #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
1 task
Jenkins BuildsClick to see older builds (36)
|
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. [ghstack-poisoned]
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. [ghstack-poisoned]
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. [ghstack-poisoned]
stefandunca
requested review from
J-Son89,
ulisesmac,
rasom,
IvanBelyakoff,
saledjenic and
dlipicar
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. [ghstack-poisoned]
J-Son89
reviewed
Jan 8, 2024
transactions/testhelpers.go
Outdated
| "math/big" | ||
|
|
||
| "github.com/stretchr/testify/mock" | ||
|
|
There was a problem hiding this comment.
nit: is this standard practice to have all these gaps between imports? would be cleaner if not imo
There was a problem hiding this comment.
I got import linting errors in CI and my local make lint doesn't work for me hence I did more than the usual separation of standard and external imports. Fixing them right now :)
There was a problem hiding this comment.
CI is back with error: File is not goimports-ed with -local github.com/ethereum/go-ethereum,github.com/status-im/status-go,github.com/waku-org/go-waku (goimports)
And my local make lint throws false positives:
make lint
ln: /Users/stefan/proj/status/status-desktop/vendor/status-go//.git/hooks: Not a directory
lint
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
WARN [linters_context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.
services/wallet/bridge/bridge.go:53:18: t.HopTx.From undefined (type *HopTxArgs has no field or method From) (typecheck)
return t.HopTx.From
^
services/wallet/bridge/bridge.go:55:22: t.CbridgeTx.From undefined (type *CBridgeTxArgs has no field or method From) (typecheck)
return t.CbridgeTx.From
^
services/wallet/bridge/bridge.go:57:29: t.ERC721TransferTx.From undefined (type *ERC721TransferTxArgs has no field or method From) (typecheck)
I'm going back to separating the imports based on account
J-Son89
approved these changes
Jan 8, 2024
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. [ghstack-poisoned]
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. [ghstack-poisoned]
✔️ status-go/prs/ios/PR-4492#11 🔹 ~4 min 38 sec 🔹 bb9b54e 🔹 📦 ios package |
stefandunca
added a commit
that referenced
this pull request
Jan 9, 2024
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. Updates status-desktop: [#13124](status-im/status-desktop#13124) ghstack-source-id: d85756b80fefd3bf7590637cb7f4dc1af615cecd Pull Request resolved: #4492
stefandunca
added a commit
that referenced
this pull request
Jan 10, 2024
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file `transactions/testhelpers.go`. Update event names for clarity and consistency in `pendingtxtracker.go`. Updates status-desktop: [#13124](status-im/status-desktop#13124) ghstack-source-id: d85756b80fefd3bf7590637cb7f4dc1af615cecd Pull Request resolved: #4492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Refactor the test helpers for pending transactions by extracting the mock implementations and helper functions into a new file
transactions/testhelpers.go. Update event names for clarity and consistency inpendingtxtracker.go.