Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check in taoensso and babashka inside ./clj-kondo into version control but prevent them from being formatted #17947

Closed
siddarthkay opened this issue Nov 20, 2023 · 0 comments · Fixed by #18328 or #18472
Closed

check in taoensso and babashka inside ./clj-kondo into version control but prevent them from being formatted #17947

siddarthkay opened this issue Nov 20, 2023 · 0 comments · Fixed by #18328 or #18472
Assignees
@ilmotta @ibrkhalil
Labels
developer-xp good-first-issue linting Linter settings & improvements

Comments

@siddarthkay
Copy link
Contributor

ref : #17783

The PR above simply adds these locations to .gitignore

  • .clj-kondo/taoensso/
  • .clj-kondo/babashka/

However as mentioned : https://clojurians-log.clojureverse.org/clj-kondo/2022-03-18 they ideally belong in the source control.
Unless the lsp configurations are modified to ignore these paths these files will get auto formatted every time the command make lint-fix is run.
The formatting varies on macos and linux systems.

The ideal solution would be to remove those entries from .gitingore and modify the lsp configurations in such a way that those folders are not formatted by the linter.
@siddarthkay siddarthkay mentioned this issue Nov 20, 2023
Merged
@siddarthkay siddarthkay added good-first-issue developer-xp linting Linter settings & improvements labels Nov 20, 2023
@siddarthkay siddarthkay mentioned this issue Nov 30, 2023
Merged
@ibrkhalil ibrkhalil self-assigned this Dec 6, 2023
@ibrkhalil ibrkhalil mentioned this issue Dec 30, 2023
Merged
@ilmotta ilmotta reopened this Jan 11, 2024
@ilmotta ilmotta self-assigned this Jan 11, 2024
@ilmotta ilmotta mentioned this issue Jan 11, 2024
Merged
2 tasks
ilmotta added a commit that referenced this issue Jan 11, 2024
@ilmotta
Fix: add back missing clj-kondo config files (#18472)
a14e228 
Fix our issues with auto-generated clj-kondo config files.

- To be extra precise, we now exclude ".clj-kondo/*" from being processed by
  clojure-lsp clean-ns.
- Formatted the .zprintrc file.

Fixes #17947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilmotta ilmotta

@ibrkhalil ibrkhalil

Labels
developer-xp good-first-issue linting Linter settings & improvements
Projects
None yet
Milestone
No milestone
3 participants
@ilmotta @ibrkhalil @siddarthkay