-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet header animation #10311
Add wallet header animation #10311
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (8)
|
80ef9f6
to
6898565
Compare
1 similar comment
48f8e53
to
494b581
Compare
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (96)Click to expand |
:extrapolate (:clamp reanimated/extrapolate)}) | ||
:shadow-radius 16 | ||
:z-index 2 | ||
:shadow-color (if (colors/dark?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flexsurfer @Ferossgp do we have some global map for dark/light colors or we are fine with having if (colors/dark?)
everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere in case of shadows, we have conditionals, and these colors are not defined in colors namespace. I actually took it from here https://github.com/status-im/status-react/pull/10311/files#diff-690bfb052fe61fb1bffec61a578ec30fR43-R45 should I add a new color to be used in shadows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ferossgp how shadows are different form other colors and why it can't live in that map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not different, but they were never used there and I followed the style of the current code. Everywhere in code where we use shadows, the color does not use a variable but uses the color value directly.
494b581
to
76b5b60
Compare
@Ferossgp all review comments are addressed? |
@churik yes |
Looks good to me! |
ping @errorists |
@Ferossgp lets merge ? |
Add reanimated lib Wallet header animation Animate android elevation Move constants into styles Ensure line width Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
76b5b60
to
c9e6f0a
Compare
Not all reanimated functions are used in this PR, but the reanimated commit is cherrypicked from other PR. This is the first iteration, the next steps are to integrate into the topbar by sharing the same animation context between 3 components.