-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment retry count when ENS fails to verify #10313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
flexsurfer
approved these changes
Apr 9, 2020
Jenkins BuildsClick to see older builds (3)
|
cammellos
force-pushed
the
bug/fix-ens-retries
branch
from
April 14, 2020 09:20
c54708e
to
5019a01
Compare
cammellos
changed the title
[DO NOT MERGE] Increment retry count when ENS fails to verify
Increment retry count when ENS fails to verify
Apr 14, 2020
98% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (89)Click to expand |
cammellos
force-pushed
the
bug/fix-ens-retries
branch
3 times, most recently
from
April 14, 2020 12:25
a53c24a
to
a9c580e
Compare
When an ENS name fails to verify, we should increment the retry count so that it back offs. All the changes are in status-go. Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ENS name fails to verify, we should increment the retry count so
that it back offs. All the changes are in status-go.
status: ready