Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update en.json #10320

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Update en.json #10320

merged 1 commit into from
Apr 14, 2020

Conversation

hesterbruikman
Copy link
Contributor

fixes: #10319

Summary

Copy change:

  • Current Hide Status previews when app switching
  • Expected: Block screenshots

Default remains for screenshots and app preview to be disabled

Testing notes

  • Go to Profile
  • Go to Privacy and security
  • See Privacy

@hesterbruikman hesterbruikman requested a review from a team as a code owner April 13, 2020 09:14
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 13, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Apr 13, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bdbca66 #1 2020-04-13 09:24:22 ~9 min android 📦apk 📲
✔️ bdbca66 #1 2020-04-13 09:24:30 ~9 min ios 📦ipa 📲
✔️ bdbca66 #1 2020-04-13 09:25:02 ~9 min android-e2e 📦apk 📲

@hesterbruikman @flexsurfer
Update en.json
a1a64ce 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit a1a64ce into develop Apr 14, 2020
Pipeline for QA automation moved this from REVIEW to DONE Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the hesterbruikman-patch-2 branch April 14, 2020 13:00
@hesterbruikman
Copy link
Contributor Author

Thanks @flexsurfer !

@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@corpetty corpetty Awaiting requested review from corpetty

@Ferossgp Ferossgp Awaiting requested review from Ferossgp

Assignees
No one assigned
Labels
None yet
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy change 'Hide previews' > 'Block screenshots'
3 participants
@hesterbruikman @status-im-auto @flexsurfer