-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single in-progress? flag for signing #10330
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (7)
|
47dedcc
to
9a9959c
Compare
@rasom @Ferossgp @flexsurfer sorry to ping again - can you please review? |
80% of end-end tests have passed
Failed tests (18)Click to expand
Passed tests (73)Click to expand |
9a9959c
to
7705dbc
Compare
0% of end-end tests have passed
Failed tests (83)Click to expand
|
@siphiuel can you rebase your PR to current develop and I'll restart e2e? |
7705dbc
to
e6511df
Compare
@churik rebased |
80% of end-end tests have passed
Failed tests (18)Click to expand
Passed tests (74)Click to expand |
246be12
to
2a4dfa8
Compare
@churik fixed |
98% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (91)Click to expand |
100% of end-end tests have passed
Passed tests (2)Click to expand
|
Tested:
|
Signed-off-by: Vitaliy Vlasov <siphiuel@gmail.com>
2a4dfa8
to
1150626
Compare
We currently use 2 different locations for
in-progress?
flag during signing: under:signing/in-progress?
and under[:signing/sign :in-progress?]
. This could cause bugs.This PR removes the former one in favour of the latter.