-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor delete account algorithm to properly remove deleted account #10354
Conversation
Pull Request Checklist
|
Jenkins Builds
|
@@ -265,7 +265,7 @@ | |||
:on-success #()}] | |||
:db (-> db | |||
(assoc :multiaccount/accounts new-accounts) | |||
(assoc-in [:wallet :accounts deleted-address] nil))} | |||
(update-in [:wallet :accounts] dissoc deleted-address))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove an extra whitespace before (update
, that's the reason why builds fail
e9ab55d
to
e0cf7bf
Compare
@rasom Updated the PR accordingly :) Thanks for the review! |
98% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (89)Click to expand |
LGTM! (Tested on iOS13.3 and Android 9) |
Prior to this commit, deleted accounts would stay in the database but set to `nil`. With this change accounts are properly removed from the database when scheduled for deletion. Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
e0cf7bf
to
f280d5a
Compare
Prior to this commit, deleted accounts would stay in the database but
set to
nil
. With this change accounts are properly removed from the databasewhen scheduled for deletion.