-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10385] [perfromance][chat] Optimize input field in chat #10421
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (3)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes introduce regression to switch between text and other panels
Now:
https://www.dropbox.com/s/l90utqx0ebkbx1s/RPReplay_Final1587661079.MP4?dl=0
Before:
https://www.dropbox.com/s/4qi97gcjxp4binp/RPReplay_Final1587661504.MP4?dl=0
[input-view {:single-line-input? single-line-input? :set-text set-text :state-text state-text}] | ||
(when (and input-text-empty? mainnet?) | ||
[basic-text-input input-text cooldown-enabled?] | ||
(when (and input-text-empty? true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this true
should not be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops, thanks
f9a852b
to
a6f74db
Compare
@Ferossgp fixed ,thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
LGTM! |
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
a6f74db
to
f73754a
Compare
fixes #10385