Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12517] Ensure that all necessary contact fields are synced #12541

Merged
merged 1 commit into from
Sep 23, 2021
Merged

[#12517] Ensure that all necessary contact fields are synced #12541

merged 1 commit into from
Sep 23, 2021

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Sep 3, 2021 •
edited
Loading

fix #12517

status: ready

@rasom rasom self-assigned this Sep 3, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Sep 3, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (64)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 093553a #1 2021-09-03 08:37:21 ~4 min android 📄log
❌ 093553a #1 2021-09-03 08:37:23 ~4 min ios 📄log
❌ 093553a #1 2021-09-03 08:38:27 ~5 min android-e2e 📄log
❌ 84c0900 #2 2021-09-03 08:50:12 ~3 min android 📄log
❌ 84c0900 #2 2021-09-03 08:50:59 ~4 min ios 📄log
❌ 84c0900 #2 2021-09-03 08:51:23 ~4 min android-e2e 📄log
❌ 3aeee12 #3 2021-09-03 09:18:18 ~3 min android 📄log
❌ 3aeee12 #3 2021-09-03 09:18:34 ~3 min android-e2e 📄log
❌ 3aeee12 #3 2021-09-03 09:18:56 ~4 min ios 📄log
❌ 3aeee12 #4 2021-09-03 09:23:35 ~3 min ios 📄log
✔️ b195e52 #4 2021-09-03 09:40:38 ~15 min android 📦apk 📲
✔️ b195e52 #5 2021-09-03 09:41:53 ~16 min ios 📦ipa 📲
✔️ b195e52 #4 2021-09-03 09:43:21 ~17 min android-e2e 📦apk 📲
✔️ 9e6b69b #5 2021-09-06 09:12:03 ~13 min android-e2e 📦apk 📲
✔️ 9e6b69b #6 2021-09-06 09:13:39 ~15 min ios 📦ipa 📲
✔️ 9e6b69b #5 2021-09-06 09:16:56 ~18 min android 📦apk 📲
✔️ d1067b8 #6 2021-09-08 08:04:43 ~14 min android-e2e 📦apk 📲
✔️ d1067b8 #7 2021-09-08 08:05:49 ~15 min ios 📦ipa 📲
✔️ d1067b8 #6 2021-09-08 08:09:10 ~18 min android 📦apk 📲
✔️ e13337f #7 2021-09-08 11:23:34 ~14 min android 📦apk 📲
✔️ e13337f #8 2021-09-08 11:24:12 ~15 min ios 📦ipa 📲
✔️ e13337f #7 2021-09-08 11:26:27 ~17 min android-e2e 📦apk 📲
✔️ fd62638 #8 2021-09-09 11:52:00 ~13 min android-e2e 📦apk 📲
✔️ fd62638 #8 2021-09-09 11:53:07 ~15 min android 📦apk 📲
✔️ fd62638 #9 2021-09-09 11:56:32 ~18 min ios 📦ipa 📲
✔️ 2d4f4b3 #9 2021-09-09 13:00:59 ~16 min android 📦apk 📲
✔️ 2d4f4b3 #9 2021-09-09 13:01:07 ~16 min android-e2e 📦apk 📲
✔️ 2d4f4b3 #10 2021-09-09 13:01:38 ~17 min ios 📦ipa 📲
✔️ df0662a #11 2021-09-09 16:20:57 ~14 min ios 📦ipa 📲
✔️ df0662a #10 2021-09-09 16:22:37 ~16 min android-e2e 📦apk 📲
✔️ df0662a #10 2021-09-09 16:24:27 ~18 min android 📦apk 📲
✔️ 90b8887 #12 2021-09-10 08:07:51 ~16 min ios 📦ipa 📲
✔️ 90b8887 #11 2021-09-10 08:10:48 ~19 min android-e2e 📦apk 📲
✔️ 90b8887 #11 2021-09-10 08:11:17 ~20 min android 📦apk 📲
✔️ 99a4115 #13 2021-09-10 10:34:55 ~16 min ios 📦ipa 📲
✔️ 99a4115 #12 2021-09-10 10:35:28 ~16 min android-e2e 📦apk 📲
✔️ 99a4115 #12 2021-09-10 10:35:32 ~16 min android 📦apk 📲
✔️ 5318af6 #13 2021-09-13 12:14:11 ~13 min android-e2e 📦apk 📲
✔️ 5318af6 #14 2021-09-13 12:15:38 ~15 min ios 📦ipa 📲
✔️ 5318af6 #13 2021-09-13 12:17:05 ~16 min android 📦apk 📲
✔️ 598341b #14 2021-09-14 08:56:39 ~14 min android 📦apk 📲
✔️ 598341b #14 2021-09-14 08:58:32 ~16 min android-e2e 📦apk 📲
✔️ 598341b #15 2021-09-14 09:01:45 ~19 min ios 📦ipa 📲
❌ 69a00cd #15 2021-09-15 09:56:49 ~15 sec android-e2e 📄log
❌ 69a00cd #15 2021-09-15 09:56:56 ~17 sec android 📄log
❌ 69a00cd #16 2021-09-15 09:56:56 ~17 sec ios 📄log
❌ 9838e1c #16 2021-09-15 10:44:39 ~18 sec android-e2e 📄log
❌ 9838e1c #17 2021-09-15 10:44:39 ~18 sec ios 📄log
❌ 9838e1c #16 2021-09-15 10:44:45 ~24 sec android 📄log
✔️ 32d4f85 #17 2021-09-15 11:35:15 ~14 min android 📦apk 📲
✔️ 32d4f85 #17 2021-09-15 11:37:10 ~16 min android-e2e 📦apk 📲
✔️ 32d4f85 #18 2021-09-15 11:41:44 ~21 min ios 📦ipa 📲
✔️ 106e8c5 #19 2021-09-16 14:14:21 ~18 min ios 📦ipa 📲
✔️ 106e8c5 #18 2021-09-16 14:18:33 ~22 min android 📦apk 📲
✔️ 106e8c5 #18 2021-09-16 14:18:44 ~22 min android-e2e 📦apk 📲
✔️ d4325c9 #19 2021-09-16 16:04:36 ~20 min android 📦apk 📲
✔️ d4325c9 #19 2021-09-16 16:06:45 ~22 min android-e2e 📦apk 📲
✔️ d4325c9 #20 2021-09-16 16:07:53 ~23 min ios 📦ipa 📲
✔️ b45dc21 #20 2021-09-17 10:09:08 ~15 min android-e2e 📦apk 📲
✔️ b45dc21 #20 2021-09-17 10:10:41 ~17 min android 📦apk 📲
✔️ b45dc21 #21 2021-09-17 10:24:04 ~30 min ios 📦ipa 📲
✔️ 242ff88 #21 2021-09-23 09:26:22 ~16 min android 📦apk 📲
✔️ 242ff88 #22 2021-09-23 09:27:08 ~16 min ios 📦ipa 📲
✔️ 242ff88 #21 2021-09-23 09:30:30 ~20 min android-e2e 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3bc6723 #22 2021-09-23 09:35:11 ~15 min android-e2e 📦apk 📲
✔️ 3bc6723 #22 2021-09-23 09:36:54 ~16 min android 📦apk 📲
✔️ 3bc6723 #23 2021-09-23 09:48:10 ~27 min ios 📦ipa 📲
✔️ 23a0ac9 #23 2021-09-23 10:39:32 ~19 min android-e2e 📦apk 📲
✔️ 23a0ac9 #23 2021-09-23 10:39:32 ~19 min android 📦apk 📲
✔️ 23a0ac9 #24 2021-09-23 10:41:38 ~21 min ios 📦ipa 📲

@rasom rasom force-pushed the feature/#12517-contacts-syncing branch from e13337f to fd62638 Compare September 9, 2021 11:37
@churik churik self-assigned this Sep 9, 2021
@churik
Copy link
Member

churik commented Sep 9, 2021 •
edited
Loading

@rasom

ISSUE 1: Error when syncing multiaccounts with some data (couldn't find steps to reproduce)

Performed a test with syncing multiaccount with such data

  1. messages in timeline
  2. blocked, removed, added contacts with nicknames and ENS
  3. group chats
  4. public chat
    After device pairing and initial syncing got an error:
    IMAGE 2021-09-09 16:40:24

Similar (but not the same) error I've got after blocking contact on paired device:

  1. 2 devices are paired
  2. add a contact on device 1
  3. block a contact on device 1
  4. error appears on device 2
    IMAGE 2021-09-09 16:52:46
    That's all logs that I can gather when clicking Report issue from this state (seems useless):
    Status.log

ISSUE 2: blocked contacts and contacts without ENS/or username added before pairing are not synced after initial sync

Steps:

  1. Device A: create multiaccount,
  • add contact (without nickname)
  • block any user from public chat
  • add contact with ENS
  • add contact with nickname
  1. Device B: restore same multiaccount
  2. Advertise Device B to Device A
  3. Sync Device A and Device B

Expected result:
can see all data from device A appeared after initial sync
Actual result:
no blocked user;
no user without nickname
OS: IOS, Android
Logs from device A: status_logs.zip
Logs from device B: Status-debug-logs.zip

ISSUE 3: Non-contact nicknames are not syncing

Maybe apart from PR, but desirable behavior as no need to add a user to contacts to set nickname for him.

Steps:

  1. Device A: create multiaccount, set nickname to some user without adding him to contact list
  2. Device B: restore same multiaccount
  3. Sync Device A and Device B

Expected result:
can see nickname on Device B
Actual result:
no nickname. it appears only after adding user a contact
OS: IOS, Android

@rasom
Copy link
Contributor Author

rasom commented Sep 10, 2021

ISSUE 1 fixed
ISSUE 3 not an issue, contacts which are not added are not synced atm
ISSUE 2 on it

@rasom
Copy link
Contributor Author

rasom commented Sep 10, 2021 •
edited
Loading

@churik issue 2 should be fixed now
checking what can be done with issue 3

@churik
Copy link
Member

churik commented Sep 10, 2021

ISSUE 4: blocked users that are not added to contacts are not synced

Steps:

  1. restore multiaccount from seed phrase on Device A and on device B
  2. pair device
  3. block some user from public chat on DeviceA

Expected result:
will be in blocked users on device B
Moreover, removing user from contacts (if it was added on device A) will remove it from blocked users on device B

Actual result:
not added to blocked users on device B

OS: IOS, Android

@churik
Copy link
Member

churik commented Sep 10, 2021 •
edited
Loading

ISSUE 5: contacts added after pairing are not shown on paired device and fetching history for public chats after adding contact becomes significantly slower on multiaccounts with some data

It is not reproducible for multiaccounts without data, checked on multiaccount with 5 contacts, several group/public chats and communities.
Seems that it is related to issue 6, as after adding contact with ENS I started to experience issues with loading chat history

Steps:

  1. restore multiaccount from seed phrase on Device A and on device B
  2. pair devices
  3. on device A add some user from public chats to contact
  4. join any public chat

Expected result:

  1. new contact will appear on device B
  2. chat history will be fetched quickly (same as for new multiaccounts)

Actual result:

  1. no contact on paired device
  2. endless loading in public chat
    Status-debug-logs.zip
    IMAGE 2021-09-10 15:39:59

ISSUE 6: contacts with ens names, added after sync are not synced and contacts without ENS are shown with @ on paired devices

photo_2021-09-10 16 41 33 jpeg 2021-09-10 16-42-09

@rasom rasom force-pushed the feature/#12517-contacts-syncing branch 2 times, most recently from 5318af6 to 598341b Compare September 14, 2021 08:41
@churik
Copy link
Member

churik commented Sep 14, 2021

All previous issues are fixed, thank you @rasom !
Found new one:

ISSUE 7: unread indicator is shown for own messages as new on paired device after syncing blocked contact

Steps:

  1. restore multiaccount from seed phrase on device A and device B
  2. pair devices
  3. device A: join public chat with history
  4. device B: open another tab (i.e. wallet)
  5. device A: start 1-1 chat with contact
  6. device A: block any user from public chat
  7. device A: send message to 1-1 chat
  8. device B: pay attention to unread indicator

Expected result:
no unread messages

Actual result:
sent messages are shown as unread

OS: IOS, Android
Monosnap 2021-09-14 17-09-05

@rasom
Copy link
Contributor Author

rasom commented Sep 15, 2021

ISSUE 7 is fixed

@churik
Copy link
Member

churik commented Sep 15, 2021

ISSUE 8: Mute and Unmute are messed up (IOS)

photo_2021-09-15 11 54 47 jpeg 2021-09-15 11-55-12

@rasom rasom force-pushed the feature/#12517-contacts-syncing branch from 9838e1c to 32d4f85 Compare September 15, 2021 11:19
@rasom rasom marked this pull request as ready for review September 15, 2021 11:28
@rasom rasom requested review from flexsurfer, cammellos and shivekkhurana and removed request for flexsurfer and cammellos September 15, 2021 11:28
@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 126
Failed tests: 21
Passed tests: 105

IDs of failed tests: 5437,6645,6272,6342,695783,695804,695812,6635,5368,6243,6224,695811,5675,6305,6284,695805,6240,6244,5758,695810,6296

Failed tests (21)

Click to expand
  • Rerun tests

    • 1. test_validation_amount_errors, id: 5437

    Device 1: *Swiping up*
    Device 1: *Waiting 400 seconds for ADI to display asset*

    Device 1: Balance ADI 0 is not changed during 400 seconds!

    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: *Getting ADI amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    3. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272

    Device 1: *Swiping up*
    Device 1: *Waiting 400 seconds for ADI to display asset*

    Device 1: Balance ADI 0 is not changed during 400 seconds!

    Device sessions

    4. test_different_status_in_timeline, id: 6342

    Device 2: *Tap on found ViewProfileButton*
    Device 2: **Looking for a message by text: some text**

    Device 2: ChatElementByText by xpath: `//*[starts-with(@text,'some text')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    5. test_commands_audio_backward_compatibility_upgrade (TestRail link is not found)

    Device 1: *Find SignInButton by xpath:* `//*[@text="Sign in"]`
    Device 1: *Tap on found SignInButton*

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    6. test_dapps_browser_several_accounts_upgrade (TestRail link is not found)

    Device 1: *Find SignInButton by xpath:* `//*[@text="Sign in"]`
    Device 1: *Tap on found SignInButton*

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    7. test_devices_activity_centre_profile_settings_upgrade (TestRail link is not found)

    Device 1: *Find SignInButton by xpath:* `//*[@text="Sign in"]`
    Device 1: *Tap on found SignInButton*

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    8. test_webview_camera_permission, id: 6635

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//*[@text="Deny" or @text="DENY"]`

    Device 1: Button by xpath: `//*[@text="Deny" or @text="DENY"]` is not found on the screen

    Device sessions

    9. test_change_log_level_and_fleet, id: 5368

    Device 1: *Find AdvancedButton by accessibility id:* `advanced-button`
    Device 1: *Find AdvancedButton by accessibility id:* `advanced-button`

    An unknown server-side error occurred while processing the command. Original error: Error executing adbExec. Original error: 'Command '/home/chef/android-sdk-linux/platform-tools/adb -P 5037 -s emulator-5554 pull /storage/emulated/0/Android/data/im.statu

    Device sessions

    10. test_keycard_can_recover_keycard_account_offline_and_add_watch_only_acc, id: 6243

    Device 1: *Selecting ADI asset*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//*[contains(@text,'ADI')]` is not found on the screen

    Device sessions

    11. test_add_account_to_multiaccount_instance_generate_new, id: 6224

    Device 1: *Find Text by xpath:* `//*[@content-desc='accountcardFTEPBKA2GQ']//*[@content-desc='account-total-value']`
    Device 1: Image differs from template to 3.444711217820461 percents

    Device 1: Account color does not match expected

    Device sessions

    12. test_devices_group_chats_upgrade (TestRail link is not found)

    Device 1: *Find SignInButton by xpath:* `//*[@text="Sign in"]`
    Device 1: *Tap on found SignInButton*

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    13. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: *Click until Button by xpath:*`//*[contains(@text, "Sync history for")]` *will be presented*
    Device 1: *Find ProfileButton by xpath:* `//*[contains(@content-desc,'5 out of 5')]`

    History is not fetched for one month!

    Device sessions

    14. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: *Find Button by xpath:* `//*[@text="Hey hey hey"]`
    Device 2: *Find Button by xpath:* `//*[@text="Hey hey hey"]`

    Device 2: Button by xpath:* `//*[@text="Hey hey hey"]` is not found on the screen

    Device sessions

    15. test_unread_previews_public_chat_version_upgrade (TestRail link is not found)

    Device 1: *Find SignInButton by xpath:* `//*[@text="Sign in"]`
    Device 1: *Tap on found SignInButton*

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    16. test_devices_sync_contact_management_upgrade (TestRail link is not found)

    Device 1: *Find SignInButton by xpath:* `//*[@text="Sign in"]`
    Device 1: *Tap on found SignInButton*

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    17. test_restore_account_from_mnemonic_to_keycard, id: 6240

    Device 1: *Getting ADI amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    18. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244

    Device 1: *Swiping up*
    Device 1: *Waiting 400 seconds for ADI to display asset*

    Device 1: Balance ADI 0 is not changed during 400 seconds!

    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: *Getting LXS amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':LXS-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    20. test_keycard_upgrade (TestRail link is not found)

    Device 1: *Swiping up*
    Device 1: *Waiting 400 seconds for ADI to display asset*

    Device 1: Balance ADI 0 is not changed during 400 seconds!

    Device sessions

    21. test_recover_account_from_new_user_seedphrase, id: 6296

    Device 1: **Logging out**
    Device 1: *Scrolling down to LogoutButton*

    'HomeView' object has no attribute 'recover_access'

    Device sessions

    Passed tests (105)

    Click to expand

    1. test_push_notifications_reactions_for_messages_in_stickers_audio_image, id: 6321
    Device sessions

    2. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    3. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 5781
    Device sessions

    4. test_open_url_with_non_english_text_connect_revoke_wallet_new_tab_open_chat_options, id: 5424
    Device sessions

    5. test_can_scan_different_links_with_universal_qr_scanner, id: 6322
    Device sessions

    6. test_creating_community_accept_membership, id: 695842
    Device sessions

    7. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    8. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    9. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    10. test_keycard_blocked_card_lost_or_frozen_flows, id: 695852
    Device sessions

    11. test_long_press_to_delete_chat, id: 5319
    Device sessions

    12. test_switching_accounts_in_dapp, id: 6232
    Device sessions

    13. test_cant_add_more_twenty_participants_to_group_chat, id: 5721
    Device sessions

    14. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    15. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    16. test_manage_assets, id: 5341
    Device sessions

    17. test_search_chat_on_home, id: 5757
    Device sessions

    18. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    19. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    20. test_share_user_profile_url_public_chat, id: 5498
    Device sessions

    21. test_create_account_short_and_mismatch_password, id: 5460
    Device sessions

    22. test_open_user_profile_long_press_on_message, id: 6267
    Device sessions

    23. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    24. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    25. test_activity_center_group_chats_trusted_contacts, id: 695771
    Device sessions

    26. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    27. test_block_user_from_one_to_one_header_check_push_notification_service, id: 5763
    Device sessions

    28. test_can_accept_or_reject_multiple_chats_from_activity_center, id: 695782
    Device sessions

    29. test_keycard_interruption_access_key_onboarding_flow, id: 6246
    Device sessions

    30. test_can_delete_several_multiaccounts, id: 6318
    Device sessions

    31. test_receive_message_while_in_different_tab_and_emoji_messages_long_press, id: 6275
    Device sessions

    32. test_unread_messages_counter_1_1_chat, id: 5362
    Device sessions

    33. test_markdown_support_in_messages, id: 5425
    Device sessions

    34. test_can_scan_qr_with_chat_key_from_home_start_chat, id: 6298
    Device sessions

    35. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    36. test_browser_managing_bookmarks, id: 6633
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_unblocked_user_is_not_added_in_contacts, id: 6213
    Device sessions

    39. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    40. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    41. test_app_on_background_by_back_button, id: 6221
    Device sessions

    42. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    43. test_dapps_permissions, id: 5738
    Device sessions

    44. test_public_clear_history_via_options_and_long_press, id: 5426
    Device sessions

    45. test_same_seed_added_inside_multiaccount_and_keycard, id: 6311
    Device sessions

    46. test_decline_invitation_to_group_chat, id: 5756
    Device sessions

    47. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    48. test_invite_to_group_chat_handling, id: 6324
    Device sessions

    49. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    50. test_keycard_frozen_card_flows, id: 695851
    Device sessions

    51. test_disable_use_history_node, id: 6332
    Device sessions

    52. test_open_user_profile_using_deep_link, id: 5441
    Device sessions

    53. test_use_pinned_mailserver, id: 5766
    Device sessions

    54. test_deny_access_camera_and_gallery, id: 6319
    Device sessions

    55. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    56. test_delete_close_all_tabs, id: 5390
    Device sessions

    57. test_add_switch_delete_custom_mailserver, id: 5436
    Device sessions

    58. test_block_user_from_public_chat, id: 5786
    Device sessions

    59. test_rename_group_chat, id: 6280
    Device sessions

    60. test_search_asset_and_currency, id: 6269
    Device sessions

    61. test_can_reset_password, id: 695850
    Device sessions

    62. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    63. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395
    Device sessions

    64. test_home_view, id: 5379
    Device sessions

    65. test_keycard_settings_pin_puk_pairing, id: 695841
    Device sessions

    66. test_can_not_connect_to_mailserver, id: 5767
    Device sessions

    67. test_can_pin_messages_in_ono_to_one_and_group_chats, id: 695847
    Device sessions

    68. test_invite_friends, id: 5433
    Device sessions

    69. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    70. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    71. test_keycard_interruption_creating_onboarding_flow, id: 5742
    Device sessions

    72. test_set_profile_picture, id: 6646
    Device sessions

    73. test_can_start_chat_from_suggestions_using_search_chat, id: 6320
    Device sessions

    74. test_set_primary_ens_custom_domain, id: 6219
    Device sessions

    75. test_nicknames_ens_group_chats, id: 6327
    Device sessions

    76. test_mention_users_not_in_chats_if_not_in_contacts, id: 6326
    Device sessions

    77. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    78. test_remove_member_from_group_chat, id: 4001
    Device sessions

    79. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    80. test_mark_all_messages_as_read_public_chat, id: 6270
    Device sessions

    81. test_block_and_unblock_user_from_group_chat_via_group_info, id: 5752
    Device sessions

    82. test_pair_devices_group_chat_different_messages_nicknames, id: 6317
    Device sessions

    83. test_can_add_existing_ens, id: 5502
    Device sessions

    84. test_notification_in_activity_center_for_mention_in_community_and_group_chat, id: 695845
    Device sessions

    85. test_custom_bootnodes, id: 5432
    Device sessions

    86. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    87. test_copy_and_paste_messages, id: 5317
    Device sessions

    88. test_show_profile_picture_of_setting, id: 6636
    Device sessions

    89. test_delete_cut_and_paste_messages, id: 5322
    Device sessions

    90. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    91. test_pass_phrase_validation, id: 5363
    Device sessions

    92. test_resolve_ipns_name, id: 6323
    Device sessions

    93. test_reply_to_message_in_chats, id: 6233
    Device sessions

    94. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    95. test_open_dapp_using_deep_link, id: 5442
    Device sessions

    96. test_wallet_set_up, id: 5335
    Device sessions

    97. test_privacy_policy_terms_of_use_node_version_need_help_in_profile, id: 5453
    Device sessions

    98. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    99. test_leave_group_chat_via_group_info, id: 3997
    Device sessions

    100. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    101. test_collectible_from_wallet, id: 5346
    Device sessions

    102. test_recover_accounts_with_certain_seedphrase, id: 5455
    Device sessions

    103. test_make_admin_member_of_group_chat, id: 5694
    Device sessions

    104. test_add_custom_network, id: 5431
    Device sessions

    105. test_add_remove_contact_via_contacts_view, id: 6312
    Device sessions

    flexsurfer
    flexsurfer reviewed Sep 16, 2021
    View reviewed changes
    src/status_im/transport/message/core.cljs
    (cond

    (seq chats)
    (do
    (when (seq contacts)
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    could you please add comment here

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @flexsurfer sorry for delay, comment is added

    @qoqobolo
    Copy link
    Contributor

    ISSUE 9: App crashes on the second paired device if mute some user on the primary device

    Steps:

    1. Recover the same multiaccount on both devices (one of them is ios)
    2. Sync devices
    3. On the ios device: join a public chat, open some user's profile, and mute the user
    4. Check the second device, the app crashes after a while

    @rasom
    Copy link
    Contributor Author

    rasom commented Sep 16, 2021

    @qoqobolo fixed

    @qoqobolo
    Copy link
    Contributor

    ISSUE 10: Crash on the secondary device if block some user on the primary paired device (any OS)

    Steps:

    1. Recover the same multiaccount on both devices
    2. Sync devices
    3. Device1: join a public chat, open some user's profile, and block the user
    4. Check Device2, the app crashes after a while

    @rasom
    Copy link
    Contributor Author

    rasom commented Sep 17, 2021

    @qoqobolo fixed

    @rasom rasom force-pushed the feature/#12517-contacts-syncing branch from b45dc21 to 242ff88 Compare September 23, 2021 09:09
    @rasom rasom force-pushed the feature/#12517-contacts-syncing branch from 3bc6723 to 23a0ac9 Compare September 23, 2021 10:19
    @rasom rasom merged commit 23a0ac9 into develop Sep 23, 2021
    @rasom rasom deleted the feature/#12517-contacts-syncing branch September 23, 2021 10:19
    @churik churik mentioned this pull request Sep 28, 2021
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer left review comments

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @rasom rasom

    @churik churik

    Labels
    Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Syncing contacts
    6 participants
    @rasom @status-im-auto @churik @qoqobolo @shivekkhurana @flexsurfer