Chat Screen Top Bar UI + new UI for user details #15204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (296)
|
alwx
force-pushed
the
feature/top-bar-chat-ui
branch
3 times, most recently
from
ab7b329
to
bf1fca4
Compare
alwx
changed the title
OmarBasem
reviewed
Mar 8, 2023
|
@alwx good job trying to implement this. I tried testing it on iOS and Android, and there seem to be some issues.
RPReplay_Final1678284703.movRPReplay_Final1678284586.movRPReplay_Final1678284542.mov |
|
Yep, Android is not currently supported, it's written in the description. Re: flickering: interesting, I don't see anything like that on emulator on my machine but will check it. |
|
Hey @alwx, there is another very important issue mentioned in this comment #14315 (comment) point number 3. Currently when trying to scroll up it will keep going back to the bottom ("top") of the list. In the below video, it went to the bottom 3 times, before being able to scroll to the beginning of the list. This increases as the number of messages increases. RPReplay-Final1678332978.MP4 |
|
Also, some messages disappeared in the above video. On scrolling to the top the 3rd time there was an album of 4 images above the butterfly image. When scrolling to the top the 4th time, the album was gone. |
alwx
force-pushed
the
feature/top-bar-chat-ui
branch
from
e87730c
to
f73f023
Compare
|
hey @alwx still relevant? is it WIP ? |
|
@flexsurfer yes it is! Was busy with other ones so this one needs an update but it's more than relevant. |
|
Finally fixed all the flickering, now the only big thing left is to make it work on Android but will be done tomorrow as well 💪 |
alwx
force-pushed
the
feature/top-bar-chat-ui
branch
from
3659311
to
0c8b887
Compare
alwx
force-pushed
the
feature/top-bar-chat-ui
branch
from
0c8b887
to
ea93b85
Compare
0% of end-end tests have passedNot executed tests (23)Failed tests (10)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
jo-mut
approved these changes
May 31, 2023
32% of end-end tests have passedNot executed tests (11)Failed tests (15)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Passed tests (7)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
🚂🚃🚃🚃🚃🚃 |
|
just wondering why it was merged without QA approve cc @churik ? |
|
Found another issue. Issue 11: top bar covers maximized composer on iOS
|
|
Another issue, on iOS after sending a message, the composer height does not update. I know this PR makes no changes to the composer, but this issue seems to be introduced from this PR, so it is good to have all possible issues tracked before merging. I am also wondering why was QA not completed? RPReplay-Final1685684944.MP4 |
@OmarBasem thanx for reprorting this one. Could you please specifi device/IOS version? Can't reproduce it on my iPhoneX, IOS 14.1. Thanx! |
This was referenced Jun 2, 2023
This was referenced Jun 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
However, due to the known issue with blurred elements (cc @flexsurfer), only iOS is supported for now.
Screen.Recording.2023-03-08.at.14.44.13.mov
Platforms
Areas that maybe impacted
Functional
Status: ready