Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature flag for swaps #19920

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

briansztamfater
Copy link
Member

fixes #19919

Summary

This PR adds a feature flag for wallet swaps

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Log in
  • Go to settings > Feature flags
  • Enable swap
  • Go to an account and verify there is a new Swap button when enabling Swap feature flag

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented May 6, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 11f03c7 #1 2024-05-06 23:11:33 ~4 min tests 📄log
✔️ 11f03c7 #1 2024-05-06 23:14:44 ~7 min android-e2e 🤖apk 📲
✔️ 11f03c7 #1 2024-05-06 23:14:45 ~7 min android 🤖apk 📲
✔️ 11f03c7 #1 2024-05-06 23:19:59 ~12 min ios 📱ipa 📲
✔️ b1b3826 #3 2024-05-08 11:52:27 ~4 min tests 📄log
✔️ b1b3826 #3 2024-05-08 11:54:02 ~5 min android-e2e 🤖apk 📲
✔️ b1b3826 #3 2024-05-08 11:55:19 ~7 min android 🤖apk 📲
✔️ b1b3826 #3 2024-05-08 11:57:28 ~9 min ios 📱ipa 📲

Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,10 @@
(ns status-im.contexts.wallet.swap.events
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Signed-off-by: Brian Sztamfater <brian@status.im>
@briansztamfater briansztamfater merged commit 842dbbb into develop May 8, 2024
6 checks passed
@briansztamfater briansztamfater deleted the feat/swap-feature-flag branch May 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Add feature flag for Wallet Swap
4 participants