Replace contacts/get-by-id realm read with app-db read #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janherich
approved these changes
Feb 5, 2018
flexsurfer
approved these changes
Feb 5, 2018
|
@dmitryn Please resolve the conflicts? |
dmitryn
force-pushed
the
3146-realm-reads
branch
2 times, most recently
from
e5343aa
to
5779625
Compare
|
@goranjovic conflicts resolved. |
|
@dmitryn more conflicts :) |
yenda
approved these changes
Feb 15, 2018
dmitryn
force-pushed
the
3146-realm-reads
branch
from
5779625
to
6e01d94
Compare
|
Conflicts have been resolved. |
4 tasks
|
Branch: PR-3212 |
dmitryn
force-pushed
the
3146-realm-reads
branch
3 times, most recently
from
b42248b
to
94da500
Compare
Signed-off-by: Dmitry Novotochinov <trybeee@gmail.com>
dmitryn
force-pushed
the
3146-realm-reads
branch
from
94da500
to
65a2f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3210
Summary:
Replace contacts/get-by-id realm read with app-db read as we don't need to touch realm since data is already in app-db.
Review notes:
This is part of further work at #3210
Just starting with changes related to
contacts/get-by-idreads so it would be easier to review one change at a time.Testing notes:
App behavior should not change. Code changed related to parts:
status: ready