[ISSUE #3313] Migrated public chat creation flow #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranjovic
approved these changes
Feb 20, 2018
flexsurfer
approved these changes
Feb 20, 2018
| (update :db navigation/replace-view :home)))) | ||
|
|
||
| (handlers/register-handler-fx | ||
| :delete-chat? |
There was a problem hiding this comment.
maybe :show-delete-chat-confirmation
There was a problem hiding this comment.
We don't use ? yet but could be a convention for handler name? -confirmation looks pretty long :)
src/status_im/chat/events.cljs
Outdated
| :delete-chat? | ||
| [re-frame/trim-v] | ||
| (fn [_ [chat-id group?]] | ||
| {:show-confirmation {:title (str (i18n/label :t/delete) "?") |
There was a problem hiding this comment.
is "?" using in all languages?
There was a problem hiding this comment.
Oh my bad, good point. Will make this label too.
src/status_im/chat/handlers.cljs
Outdated
| (re-frame/dispatch [:remove-chat current-chat-id])))) | ||
|
|
||
| (handlers/register-handler-fx | ||
| :leave-group-chat? |
There was a problem hiding this comment.
maybe :show-leave-group-chat-confirmation ?
| :clear-history | ||
| (fn [{{:keys [current-chat-id] :as db} :db} _] | ||
| {:db (assoc-in db [:chats current-chat-id :messages] {}) | ||
| :delete-messages current-chat-id})) | ||
|
|
||
| (handlers/register-handler-fx | ||
| :clear-history? |
There was a problem hiding this comment.
show-clear-history-confirmation ?
Automated test results:test_contact_profile_view:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_group_chat_messages:x:Test Steps & Error message:
test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:x:Test Steps & Error message:
test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:test_public_chat:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:x:Test Steps & Error message:
test_transaction_send_command_one_to_one_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
jeluard
force-pushed
the
feature/#3313
branch
from
d7a8576
to
360917c
Compare
|
Branch: PR-3381 |
|
|
Please also add accessibility lables here cc: @lukaszfryc |
|
To follow up on @asemiankevich comment -- we want to kick off iOS end-end automation and to do it efficiently we need accessibility labels for elements user may interact with (buttons, list items, menu options, etc). Whenever UI changes we should consider updating the labels. Here is example of accessibility labels we want to introduce in another part of the app #3394 |
jeluard
force-pushed
the
feature/#3313
branch
2 times, most recently
from
875136d
to
2fbc224
Compare
|
all above issues are fixed, 1 more minor issue - wrong alignment for input in iOS
|
|
@asemiankevich Great thanks! Can we left the alignment issue out? I will fix it part of #3372 |
|
@jeluard yes, for sure! |
jeluard
force-pushed
the
feature/#3313
branch
2 times, most recently
from
61aa845
to
eebfed3
Compare
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
jeluard
force-pushed
the
feature/#3313
branch
from
eebfed3
to
33f1d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3313
fixes #3341
Note that input errors have not been migrated to new paradigm.
Summary:
Migrated public chat creation flow to latest mockups. Also added popup prompt to destructive actions (applies to group chat too)
Steps to test:
status: ready