Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9975] Do not throw exception on invalid ens recipient #10001

Merged
merged 1 commit into from
Feb 7, 2020
Merged

[#9975] Do not throw exception on invalid ens recipient #10001

merged 1 commit into from
Feb 7, 2020

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Feb 7, 2020 •
edited by StatusWrike
Loading

in #9999 I didn't check the case when invalid ens name is passed. string/trim fails on nil value.

status: ready

@rasom rasom requested a review from a team as a code owner February 7, 2020 16:43
@auto-assign auto-assign bot removed the request for review from a team February 7, 2020 16:43
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Feb 7, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 39ea685 #1 2020-02-07 16:54:55 ~11 min ios 📦ipa 📲
✔️ 39ea685 #1 2020-02-07 16:55:51 ~12 min android 📦apk 📲
✔️ 39ea685 #1 2020-02-07 16:55:53 ~12 min android-e2e 📦apk 📲

@rasom rasom self-assigned this Feb 7, 2020
@rasom rasom merged commit 39ea685 into develop Feb 7, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@rasom rasom deleted the fix/#9999-invalid-ens branch February 25, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda approved these changes

@vitvly vitvly Awaiting requested review from vitvly

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasom @status-im-auto @yenda