Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Linux Support #3186

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Arch Linux Support #3186

merged 1 commit into from
Feb 9, 2018

Conversation

azer
Copy link
Contributor

@azer azer commented Feb 1, 2018

Summary

It creates umbrella commands for all Linux packages and adds support for Arch Linux' package manager pacman.

Testing

You can run it inside a Docker with Arch Linux image. I've tested it in Arch before submitting this PR though.

Status: ready

@status-github-bot
Copy link

Thanks for making your first PR here!

@jeluard
Copy link
Contributor

jeluard commented Feb 2, 2018

Thanks for the contribution @azer ! So it works fine with pacman using existing package names used for apt? I would assume this could be incorrect for some other package manager.

@azer
Copy link
Contributor Author

azer commented Feb 2, 2018

@jeluard I think you missed the part I added separete pacman functions; https://github.com/status-im/status-react/pull/3186/files#diff-14c08a9aa99b4897b4a08988fb7d8d88R130

GitHub
Summary It creates umbrella commands for all Linux packages and adds support for Arch Linux' package manager pacman. Testing You can run it inside a Docker with Arch Linux image. I've tested it in ...

@jeluard
Copy link
Contributor

jeluard commented Feb 2, 2018

We use apt to install some packages (see linux_install "$package"). So all package names must be the same for both pacman and apt?

@azer
Copy link
Contributor Author

azer commented Feb 2, 2018

@jeluard gotcha! Currently package names are same on both sides (only maven and nodejs), it'd require some sort of mapping as the list grows though...

@jeluard
Copy link
Contributor

jeluard commented Feb 2, 2018

Makes sense! Can you add a comment in the script so that we keep this in mind for eventual future changes?

@azer
Copy link
Contributor Author

azer commented Feb 2, 2018

Thanks, just added a comment.

@jeluard jeluard requested review from dmitryn and yenda February 2, 2018 12:27
@oskarth
Copy link
Contributor

oskarth commented Feb 5, 2018

Thanks @azer!

@oskarth
Copy link
Contributor

oskarth commented Feb 5, 2018

@azer Can you please squash your commits into one first? (We do merges outside of GH for code signing with a script).

@azer
Copy link
Contributor Author

azer commented Feb 7, 2018

@oskarth squashed

@status-im status-im deleted a comment from statustestbot Feb 9, 2018
@status-im status-im deleted a comment from statustestbot Feb 9, 2018
… Arch Linux' package manager pacman

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit d0dff14 into status-im:develop Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants