Phoenix 1.2 uses lower version of Poison #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn developers that Phoenix 1.2 still uses older Poison than the one recommended by Arc stavro#180
rbeene
reviewed
Apr 22, 2017
README.md
Outdated
| @@ -25,6 +25,9 @@ defp deps do | |||
| end | |||
| ``` | |||
|
|
|||
| > Note: If you use Arch along Phoenix framework then Phoenix `"=< 1.2"` uses `{:poison, "~> 2.0"}`. Therefore you may want to specify `"poison: "~> 2.1"` | |||
There was a problem hiding this comment.
Arch should be Arc. Otherwise, thanks for opening this PR as I ran into this specific issue. 👍
|
@rbeene sorry for the typo, fixed ;) |
|
Hey @equivalent. This seems to have been stale for 18 months and you've likely moved on, but if you're still using the project and want to contribute, but might considering updating this to mention Phoenix switching to Jason instead of Poison in newer versions as well. |
|
Closing this. Would like to move the Jason route as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn developers that Phoenix 1.2 still uses older Poison than the one recommended by Arc
#180