Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing binary data structs as attachments #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow passing binary data structs as attachments #87

wants to merge 1 commit into from

Conversation

azhi
Copy link
Contributor

@azhi azhi commented Jan 16, 2018

arc allows storing %{filename: filename, binary: data},
and now arc_ecto allows these structs to be accepted in
cast_attachments

fixes #54

@azhi azhi mentioned this pull request Jan 16, 2018
Merged
pedep
pedep approved these changes Jan 16, 2018
View reviewed changes
Copy link

@pedep pedep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another one!
This seems to be a much requested feature - Nice to have it completed 🎉

Specs run on my machine 👍

@spscream
Copy link

I'm curious when this would be merged?

@wethanet
Copy link

@stavro is there any chance of this being merged soon? Or is there another solution that you'd recommend.

@massetech
Copy link

That would be very usefull ; could you pls merge it ? txs

@Stanislav-Lapata
Copy link

up

@gen1321
Copy link

gen1321 commented Sep 19, 2018

merge plz

@NeverHappened
Copy link

Is there a reason you're not merging this? Really need this PR

@jalcine jalcine mentioned this pull request Oct 12, 2018
Open
@artempankov
Copy link

merge plz

@gabrielpra1
Copy link

I'm also looking forward for this merge!

@jungrafael
Copy link

To have this merged would be of great help!

@OvermindDL1 OvermindDL1 mentioned this pull request Jan 10, 2019
Open
@bnenu bnenu mentioned this pull request Jan 16, 2019
Open
@tiagonbotelho
Copy link

Up, it would be great to have this merged, for now I had to run my own fork to go around the situation.. thanks @azhi for finding a solution 🙇

@jprincipe
Copy link

@tiagonbotelho would you mind sharing that fork? @stavro is this repo being maintained any more? There are a lot of very useful PRs that are over a year old just gathering dust.

@tiagonbotelho
Copy link

@jprincipe sure thing I forked it here: https://github.com/duffelhq/arc_ecto 👍 I just fixed what was blocking my work. I have no current plans of maintaining my own fork. But if that changes in the future I'll be sure to post it here 😊

@jprincipe
Copy link

Thanks @tiagonbotelho, I ended up forking master and manually pulled in the PR from @azhi. I'm going to try and go through some of the existing PRs and see what makes sense to pull in. Unsure if I'll continue to maintain it though.

@azhi
allow passing binary data structs as attachments
4a4fe6e 
arc allows storing `%{filename: filename, binary: data}`,
and now arc_ecto allows these structs to be accepted in
`cast_attachments`

fixes stavro#54
@azhi azhi force-pushed the allow-binary-data-attachments branch from 9c6c9d5 to 4a4fe6e Compare June 19, 2019 15:49
@achempion achempion mentioned this pull request Sep 16, 2019
Merged
@bnymn
Copy link

bnymn commented Apr 12, 2020

Hi @stavro ,

Do you have any plans to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedep pedep pedep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass binary to cast_attachments