Add option for custom HipChat installs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A optional HipChat BaseUrl has been added to allow publishing notifications to a user specified URL, instead of only to a hosted HipChat install.
|
I don't know how to install a locally generated Seq App, so I wasn't able to completely test my change. |
| @@ -52,7 +60,7 @@ public class HipChatReactor : Reactor, ISubscribeTo<LogEventData> | |||
| { | |||
| using (var client = new HttpClient()) | |||
| { | |||
| client.BaseAddress = new Uri("https://api.hipchat.com/v2/"); | |||
| client.BaseAddress = new Uri(HipChatBaseUrl ?? DefaultHipChatBaseUrl); | |||
There was a problem hiding this comment.
Thanks for your contrib!
I'm unsure about Seq's behaviour, but it would feel more safe using string.IsNullOrWhitespace to check for empty value.
Check the following comment for how to run locally: #1 (comment)
It is unknown exactly how Seq sets optional properties. Therefore, to be safe, the optional HipChat base URL is now checking for both null and whitespace, instead of using the coalescing operator.
|
Updated. Thanks for the tip on using a local nuget feed, I don't know how I missed it! |
kristofferlindvall
added a commit
that referenced
this pull request
Aug 12, 2015
Add option for custom HipChat installs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A optional HipChat BaseUrl has been added to allow publishing notifications to a user specified URL, instead of only to a hosted HipChat install.