Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harder requirements #120

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Harder requirements #120

merged 2 commits into from
Jun 29, 2020

Conversation

okin
Copy link
Collaborator

@okin okin commented Nov 23, 2019

katprept is still running with Python 2.7 and 3.4.

We need to be a little more specific about our requirements here since a lot of libs are dropping support for Python 2 and old 3.x versions.

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   11.06%   11.06%           
=======================================
  Files          16       16           
  Lines        1971     1971           
=======================================
  Hits          218      218           
  Misses       1753     1753

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6bbf6...2f33c3b. Read the comment docs.

@rapgro
Copy link

rapgro commented Nov 23, 2019

No. Python2 is announced for EOL. Why don't support any new version of Python3?

@rapgro
Copy link

rapgro commented Nov 23, 2019

#117

@okin
Copy link
Collaborator Author

okin commented Nov 23, 2019

No. Python2 is announced for EOL. Why don't support any new version of Python3?

I talked to @stdevel in private and my impression was that he wanted to still support RHEL / CentOS 7 and therefore there is support for Python 2.7.

I'm all in for dropping Python 2 support. As a sidenote I'm working on further improving the Python 3 support. But I feel this should be separate discussions.

@rapgro
Copy link

rapgro commented Nov 24, 2019

Indeed, RHEL / CentOS 7 still has python2. But there's also (rudimental) support for python3, some packages within EPEL additionally that leads me to ensure nothing about all requirements available to get a fully working package. I'd say we should try with python3 in RHEL / CentOS 8 then.
Right, it's not the right place to discuss the details here in a PR.

@stdevel
Copy link
Owner

stdevel commented Jun 29, 2020

Sorry for the last delay - I just had no time for katprep due to other projects.

In the meantime I decided to drop support for Python 2.7.x. The most distributions already dropped support for this specific version. Even on EL7 you can't barely live without newer Python versions now as many projects also dropped support.

Thanks for your contribution - just merged your code!

@stdevel stdevel closed this Jun 29, 2020
@stdevel stdevel reopened this Jun 29, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #120 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   11.00%   11.06%   +0.05%     
==========================================
  Files          16       16              
  Lines        1971     1971              
==========================================
+ Hits          217      218       +1     
+ Misses       1754     1753       -1     
Impacted Files Coverage Δ
katprep/clients/SpacewalkAPIClient.py 46.15% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6bbf6...2f33c3b. Read the comment docs.

@stdevel stdevel merged commit 5ee6738 into stdevel:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants