Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent (Wallet is broken in Korean language mode) #2218

Merged
merged 7 commits into from
Dec 23, 2017

Conversation

ianpark
Copy link
Contributor

@ianpark ianpark commented Dec 23, 2017

Fixes #2217.

Wallet page does not work in Korean version due to the wrong string formatting in ko.json.
Please review and deliver as soon as possible, as Korean are unable to use the wallet.
Sorry for the trouble.

Issue Number:
#2217

Workaround:
Change the language to English

ianpark and others added 7 commits December 17, 2017 06:41
…nity.

Contributed Steemians:
@asbear @bree1042 @Chocolate1st @sjchoi @feyee95 @crowsaint @happyworkingmom @clayop @coffeenut @kmlee @sinner264 @seaturtle @yangmok701
…nity.

Fix 스팀 -> STEEM when it mentions the currency name.
Otherwise I will 스팀 as is because it is much better than "Steem" in Korean website. Google translator may tranlate 스팀 to Steam, but actually all the korean Steemians thinks 스팀 is Steem and we all agreed on it.

Contributed Steemians:
@asbear @bree1042 @Chocolate1st @sjchoi @feyee95 @crowsaint @happyworkingmom @clayop @coffeenut @kmlee @sinner264 @seaturtle @yangmok701
The latest Korean translation contained a invalid formatting so it broke the wallet page.
Tested on my local Condenser.
@ianpark
Copy link
Contributor Author

ianpark commented Dec 23, 2017

@relativityboy @originated Please take a look if you can. Thanks ;)

@gl2748 gl2748 changed the title Fox for issue #2217 - urgent (Wallet is broken in Korean language mode) Urgent (Wallet is broken in Korean language mode) Dec 23, 2017
Copy link
Contributor

@gl2748 gl2748 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:
#2219
All looks good. I do not understand korean by inclusion of user name is apparent.

@gl2748 gl2748 merged commit 65bc18f into steemit:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants