remove mysql page view tracking #2750
Conversation
closes steemit/steempunks#321
remove page_view api resource
do not try to display a page view count
only record page views to overseer
src/app/utils/ServerApiClient.js
Outdated
| if (last_page_promise && page === last_page) return last_page_promise; | ||
| if (window.ga) { | ||
| // virtual pageview | ||
| window.ga('set', 'page', page); | ||
| window.ga('send', 'pageview'); | ||
| } | ||
| api.call('overseer.pageview', { page, referer: ref, account }, error => { | ||
| // if (error) console.warn('overseer error', error, error.data); | ||
| last_page_promise = api.callAsync('overseer.pageview', { |
There was a problem hiding this comment.
does this need to be wrapped in a process.env.BROWSER check?
There was a problem hiding this comment.
yes, good point :)
There was a problem hiding this comment.
err actually oddly enough we're fixing a previous bug here; looks like we have been double-recording ssr pageviews to overseer !
There was a problem hiding this comment.
@roadscape "fixed"
| className="PageViewsCounter" | ||
| title={tt('g.views', { count: views }) + suffix} | ||
| > | ||
| <Icon name="eye" /> {views.toLocaleString()} |
There was a problem hiding this comment.
if we might reuse this at some point we should keep the render function
There was a problem hiding this comment.
just because classnames, css, icon are all known working
There was a problem hiding this comment.
i'd rather not include it as commented code; we can find the old markup here in git
|
Code looks good, let's merge after dev test |
Before
After
|
|
Removing views is a nice change. This was becoming a very wrong number with the emergence of new apps on the steem blockchain. |
closes steemit/steempunks#321
remove page_view api resource
do not try to display a page view count
only record page views to overseer