Community - Fix wallet page so that transfer history is not corrupted #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #2970 #2968 #2967.
The problem is that mergeDeep when given two parallel lists will merge each entry by index, and this causes some weird behavior when the two transfer history lists aren't exactly matching up. Instead, the transfer history should be replacing the old transfer history. This change attempts to do just that.
One problem is that I was unable to reproduce the linked errors predictably, so I will try to see if there's a sequence that can reproduce. For now, just wanted to show the proposed fix.
I believe this should only happen in RECEIVE_STATE, and not in the other pieces of code that merge accounts (since they are used on account fetch calls that do not contain transfer history).