Community - Add Spee.ch support to Condenser #3167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Steemit team, would appreciate a review and some help on getting this integrated :) |
roadscape
changed the title
|
@kodxana can you look into the syntax issues from the build logs? |
fix syntax
|
Would appreciate a code review now that the builds are passing :) |
roadscape
suggested changes
Apr 24, 2019
There was a problem hiding this comment.
Hi @kodxana, this doesn't seem like a complete implementation; see https://github.com/steemit/condenser/pull/3164/files for reference.
|
Hi @kodxana, I am closing this for now. Please open a new PR if you decide to pick this back up. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request I want to add support for videos from Spee.ch condenser.
If this PR need some changes just tell me :)