Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database api details #404

Merged
merged 6 commits into from
Jan 2, 2019
Merged

Conversation

inertia186
Copy link
Contributor

I filled in details that were missing from database_api definitions. Some of them were outlined in condenser_api and copied over to database_api and then adjusted to the AppBase parameters. Some of them are unique to database_api. They all have curl examples that pass verification as of steem_rev: a99266.

$ rake test:curl[database_api]
node: https://api.steemit.com; blockchain_version: 0.20.6; steem_rev: a99266; fc_rev: a99266
Testing database_api.find_account_recovery_requests ... √
Testing database_api.find_accounts ... √
Testing database_api.find_change_recovery_account_requests ... √
Testing database_api.find_comments ... √
Testing database_api.find_decline_voting_rights_requests ... √
Testing database_api.find_escrows ... √
Testing database_api.find_limit_orders ... √
Testing database_api.find_owner_histories ... √
Testing database_api.find_savings_withdrawals ... √
Testing database_api.find_sbd_conversion_requests ... √
Testing database_api.find_vesting_delegation_expirations ... √
Testing database_api.find_vesting_delegations ... √
Testing database_api.find_votes ... √
Testing database_api.find_withdraw_vesting_routes ... √
Testing database_api.find_witnesses ... √
Testing database_api.get_active_witnesses ... √
Testing database_api.get_config ... √
Testing database_api.get_current_price_feed ... √
Testing database_api.get_dynamic_global_properties ... √
Testing database_api.get_feed_history ... √
Testing database_api.get_hardfork_properties ... √
Testing database_api.get_order_book ... √√
Testing database_api.get_potential_signatures ... √
Testing database_api.get_required_signatures ... √
Testing database_api.get_reward_funds ... √
Testing database_api.get_transaction_hex ... √
Testing database_api.get_version ... √
Testing database_api.get_witness_schedule ... √
Testing database_api.list_account_recovery_requests ... √
Testing database_api.list_accounts ... √
Testing database_api.list_change_recovery_account_requests ... √
Testing database_api.list_comments ... √
Testing database_api.list_decline_voting_rights_requests ... √
Testing database_api.list_escrows ... √
Testing database_api.list_limit_orders ... √
Testing database_api.list_owner_histories ... √
Testing database_api.list_savings_withdrawals ... √
Testing database_api.list_sbd_conversion_requests ... √
Testing database_api.list_vesting_delegation_expirations ... √
Testing database_api.list_vesting_delegations ... √
Testing database_api.list_votes ... √
Testing database_api.list_withdraw_vesting_routes ... √
Testing database_api.list_witness_votes ... √
Testing database_api.list_witnesses ... √
Testing database_api.verify_account_authority ... √
Testing database_api.verify_authority ... √
Testing database_api.verify_signatures ... √

node: https://api.steemit.com; blockchain_version: 0.20.6; steem_rev: a99266; fc_rev: a99266
Testing database_api.find_account_recovery_requests ... √
Testing database_api.find_accounts ... √
Testing database_api.find_change_recovery_account_requests ... √
Testing database_api.find_comments ... √
Testing database_api.find_decline_voting_rights_requests ... √
Testing database_api.find_escrows ... √
Testing database_api.find_limit_orders ... √
Testing database_api.find_owner_histories ... √
Testing database_api.find_savings_withdrawals ... √
Testing database_api.find_sbd_conversion_requests ... √
Testing database_api.find_vesting_delegation_expirations ... √
Testing database_api.find_vesting_delegations ... √
Testing database_api.find_votes ... √
Testing database_api.find_withdraw_vesting_routes ... √
Testing database_api.find_witnesses ... √
Testing database_api.get_active_witnesses ... √
Testing database_api.get_config ... √
Testing database_api.get_current_price_feed ... √
Testing database_api.get_dynamic_global_properties ... √
Testing database_api.get_feed_history ... √
Testing database_api.get_hardfork_properties ... √
Testing database_api.get_order_book ... √√
Testing database_api.get_potential_signatures ... √
Testing database_api.get_required_signatures ... √
Testing database_api.get_reward_funds ... √
Testing database_api.get_transaction_hex ... √
Testing database_api.get_version ... √
Testing database_api.get_witness_schedule ... √
Testing database_api.list_account_recovery_requests ... √
Testing database_api.list_accounts ... √
Testing database_api.list_change_recovery_account_requests ... √
Testing database_api.list_comments ... √
Testing database_api.list_decline_voting_rights_requests ... √
Testing database_api.list_escrows ... √
Testing database_api.list_limit_orders ... √
Testing database_api.list_owner_histories ... √
Testing database_api.list_savings_withdrawals ... √
Testing database_api.list_sbd_conversion_requests ... √
Testing database_api.list_vesting_delegation_expirations ... √
Testing database_api.list_vesting_delegations ... √
Testing database_api.list_votes ... √
Testing database_api.list_withdraw_vesting_routes ... √
Testing database_api.list_witness_votes ... √
Testing database_api.list_witnesses ... √
Testing database_api.verify_account_authority ... √
Testing database_api.verify_authority ... √
Testing database_api.verify_signatures ... √
Copy link
Contributor

@jredbeard jredbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the "new" database_api methods will likely be much more utilized moving forward, this is an excellent and necessary addition to the devportal. Thank you @inertia186 👍 👏⭐️

@jredbeard jredbeard merged commit 6b835b4 into steemit:develop Jan 2, 2019
@inertia186 inertia186 deleted the database-api-details branch January 3, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants