Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hive_api.py #92

Closed
2 tasks
roadscape opened this issue Feb 15, 2018 · 1 comment
Closed
2 tasks

update hive_api.py #92

roadscape opened this issue Feb 15, 2018 · 1 comment
Labels
priority/low
Milestone
1.5

Comments

@roadscape
Copy link
Contributor

roadscape commented Feb 15, 2018 •
edited
Loading

hive_api.py methods were written before the condenser_api.py compatibility layer which introduced cursor-based pagination. At this point all the hive_api queries still work, but (a) may not be using optimal indices/interfaces, and (b) may benefit from borrowing cursor pagination from condenser_api, since it can be more convenient and resilient to shifts in underling data sets.

  • condenser_api.py improvements to be merged/refactored back into hive_api.py.
  • update json schema (TODO: automate this via reflection)
@roadscape roadscape modified the milestones: 1.5, 1.0 Feb 15, 2018
roadscape added a commit that referenced this issue Feb 21, 2018
@roadscape
disable some hive apis pending #92, remove legacy endpoint and test s…
4e59c4d 
…hims #49
@roadscape roadscape mentioned this issue Feb 21, 2018
Closed
10 tasks
@roadscape roadscape modified the milestones: 1.0, 1.5 Feb 26, 2018
@roadscape
Copy link
Contributor Author

Outdated. Partially addressed in #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/low
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@roadscape