New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 strings f*ck up generichash #93

Closed

stef opened this issue Jan 31, 2020 · 1 comment

Owner

stef commented Jan 31, 2020 •

edited

Loading

>>> import pysodium
>>> pysodium.crypto_generichash( 'salt0') == pysodium.crypto_generichash( 'salt1')
True
>>> pysodium.crypto_generichash(b'salt0') == pysodium.crypto_generichash(b'salt1')
False
>>>

observe that only the type of the salt[01] input changed from str to byte, and only for bytes it gives the correct output.

may hastur haunt the dreams of those responsible for py3 string "handling"

The text was updated successfully, but these errors were encountered:

stef added a commit that referenced this issue


          [fix] #93 py3 f*cking up strings

06fb17f

Owner Author

stef commented Jan 31, 2020

fixed in 06fb17f

stef closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment