tpm2: Enable NVRAM in NVChip file case #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 509
💛 - Coveralls |
stefanberger
force-pushed
the
master.next
branch
3 times, most recently
from
8b6acdb
to
dd583f4
Compare
Split off the part that was handling the NVChip file in _plat__NVEnable and call this new function _plat__NVEnable_ChipFile so we can call it separately in case the caller works with the plain NVChip file. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
When no callbacks are set and the plain NVChip file is used it wasn't possible to save the state of the TPM 2 after a TPMLIB_Terminate() TPMLIB_MainInit() sequence with a cached state (TPMLIB_SetState) since in this case the NVRAM was not initialized. We now initialize the NV in case no callback for restoring the state is set. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
master.next
branch
from
dd583f4
to
2f353c8
Compare
stefanberger
force-pushed
the
master.next
branch
2 times, most recently
from
5153a9c
to
9efd31f
Compare
stefanberger
changed the title
…tate Extend the existing test case with extending PCR 10 and reading back the result, then storing the state blobs and setting them and checking the value of PCR 10 again. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Add a test case that test the restoring of the permanent state that must have a persisted key. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
master.next
branch
2 times, most recently
from
101041c
to
c631d95
Compare
Leave a note in the TPMLIB_RegisterCallbacks() function about the effects of leaving the store- and loaddata functions in the interface unset. Leave another not in TPMLIB_MainInit() to not use the library without calling TPMLIB_RegiserCallbacks(). Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
master.next
branch
from
c631d95
to
7afb793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no callbacks are set and the plain NVChip file is used it wasn't
possible to save the state of the TPM 2 after a TPMLIB_Terminate()
TPMLIB_MainInit() sequence with a cached state (TPMLIB_SetState) since
in this case the NVRAM was not initialized. We now initialize the NV
in case no callback for restoring the state is set.
This series of patches fixes the issue and adds test cases around this.