Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off and fix RLlib demo notebook #42

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Split off and fix RLlib demo notebook #42

merged 5 commits into from
Jul 20, 2023

Conversation

stefanbschneider
Copy link
Owner

The demo notebook used to contain everything: Customization, single-agent with SB3 and multi-agent with RLlib. It had several issues that are resolved in this PR:

  • The SB3 version was pinned to some alpha that supported Gymnasium. Now, it's pinned to newly released version v2.0.0.
  • RLlib was not pinned to any version, installed the latest one (2.5.1), which broke the notebook (RLlib resource error in demo notebook #38 ). RLlib is now pinned to v2.5.1 and the notebook is adjusted to work correctly with it.
  • SB3 and RLlib need different Gymnasium versions, leading to conflict within the notebook. This PR splits the RLlib part off into a separate notebook, avoiding the compatibility issues.

Closes #38 , #31, and #32

@stefanbschneider
Split demo notebook into 3 parts & fix RLlib
61a1f66 
Still needs more work + fix for SB3 notebook
@stefanbschneider
Pin SB3 to v2.0.0 in demo notebook
f5ae4a6 
One main demo notebook with SB3 for single-agent.
One RLlib notebook for multi-agent.
@stefanbschneider
Link both new notebooks in readme
681dd05
@stefanbschneider
Fix colab batch in readme
81b0b94
@stefanbschneider stefanbschneider added bug Something isn't working documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Jul 20, 2023
@stefanbschneider stefanbschneider self-assigned this Jul 20, 2023
@stefanbschneider stefanbschneider merged commit 5ec0ded into main Jul 20, 2023
6 checks passed
@stefanbschneider stefanbschneider deleted the fix-rllib-notebook branch July 20, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanbschneider stefanbschneider

Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RLlib resource error in demo notebook
1 participant
@stefanbschneider