Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.3 #81

Merged
merged 3 commits into from Jan 16, 2018
Merged

Drop support for EOL Python 3.3 #81

merged 3 commits into from Jan 16, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 16, 2018

Python 3.3 was dropped in dependency python-json-pointer in stefankoegl/python-json-pointer#28.


PS The intro text needs updating to something like "Applying JSON Patches in Python 2.7 and 3.4+", or just "Applying JSON Patches in Python".

image

@stefankoegl
Copy link
Owner

Thanks!

@stefankoegl
Copy link
Owner

I've updated the intro text as suggested

@stefankoegl stefankoegl merged commit 0642254 into stefankoegl:master Jan 16, 2018
@hugovk hugovk deleted the rm-3.3 branch January 16, 2018 14:49
@ilovezfs
Copy link

@stefankoegl I think a new release of json-patch with this PR included is needed on PyPI. On Homebrew CI for ansible, we're seeing

==> /usr/local/Cellar/ansible/2.4.3.0_4/libexec/bin/pip install -v --no-deps --no-binary :all: --ignore-installed /private/tmp/ansible--jsonpatch-20180317-6776-bt14xu/jsonpatch-1.21
Processing /private/tmp/ansible--jsonpatch-20180317-6776-bt14xu/jsonpatch-1.21
  Running setup.py (path:/private/tmp/pip-soBG6C-build/setup.py) egg_info for package from file:///private/tmp/ansible--jsonpatch-20180317-6776-bt14xu/jsonpatch-1.21
    Running command python setup.py egg_info
    warning: pypandoc module not found, could not convert Markdown to RST
    running egg_info
    creating pip-egg-info/jsonpatch.egg-info
    writing requirements to pip-egg-info/jsonpatch.egg-info/requires.txt
    writing pip-egg-info/jsonpatch.egg-info/PKG-INFO
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/tmp/pip-soBG6C-build/setup.py", line 84, in <module>
        **OPTIONS
      File "/usr/local/Cellar/ansible/2.4.3.0_4/libexec/lib/python2.7/site-packages/setuptools/__init__.py", line 129, in setup
        return distutils.core.setup(**attrs)
      File "/usr/local/opt/python@2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 151, in setup
        dist.run_commands()
      File "/usr/local/opt/python@2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
        self.run_command(cmd)
      File "/usr/local/opt/python@2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
        cmd_obj.run()
      File "/usr/local/Cellar/ansible/2.4.3.0_4/libexec/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 271, in run
        writer(self, ep.name, os.path.join(self.egg_info, ep.name))
      File "/usr/local/Cellar/ansible/2.4.3.0_4/libexec/lib/python2.7/site-packages/setuptools/command/egg_info.py", line 604, in write_pkg_info
        metadata.write_pkg_info(cmd.egg_info)
      File "/usr/local/opt/python@2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 1106, in write_pkg_info
        self.write_pkg_file(pkg_info)
      File "/usr/local/Cellar/ansible/2.4.3.0_4/libexec/lib/python2.7/site-packages/setuptools/dist.py", line 76, in write_pkg_file
        file.write('%s: %s\n' % (field, attr_val))
    UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 16: ordinal not in range(128)

@stefankoegl
Copy link
Owner

I have just pushed tag 1.22 - it should be released to PyPI within minutes.

@ilovezfs
Copy link

ilovezfs commented Apr 2, 2018

Awesome! Thank you :)

halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Apr 9, 2018
The following error is seen when do_install is run

| UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in
| position 16: ordinal not in range(128) ERROR: python setup.py
| install execution failed.

This is reported in the upstream project as part of pull request #81
stefankoegl/python-json-patch#81

Since a release is not yet available with the required fix we must
apply the fix as a patch.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Apr 9, 2018
The following error is seen when do_install is run

| UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in
| position 16: ordinal not in range(128) ERROR: python setup.py
| install execution failed.

This is reported in the upstream project as part of pull request #81
stefankoegl/python-json-patch#81

Since a release is not yet available with the required fix we must
apply the fix as a patch.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Apr 9, 2018
The following error is seen when do_install is run

| UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in
| position 16: ordinal not in range(128) ERROR: python setup.py
| install execution failed.

This is reported in the upstream project as part of pull request #81
stefankoegl/python-json-patch#81

Since a release is not yet available with the required fix we must
apply the fix as a patch.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
anujm1 pushed a commit to anujm1/meta-openembedded that referenced this pull request Apr 9, 2018
The following error is seen when do_install is run

| UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in
| position 16: ordinal not in range(128) ERROR: python setup.py
| install execution failed.

This is reported in the upstream project as part of pull request openembedded#81
stefankoegl/python-json-patch#81

Since a release is not yet available with the required fix we must
apply the fix as a patch.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
kraj pushed a commit to YoeDistro/meta-python2 that referenced this pull request Jan 20, 2020
The following error is seen when do_install is run

| UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in
| position 16: ordinal not in range(128) ERROR: python setup.py
| install execution failed.

This is reported in the upstream project as part of pull request #81
stefankoegl/python-json-patch#81

Since a release is not yet available with the required fix we must
apply the fix as a patch.

(From meta-openembedded commit: 3aa3c374ca7cd0850bdede6a404936737abb4068)

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Tim Orling <ticotimo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants