Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix situation where AUR package cannot build as is from AUR, but user has the package installed #20

Merged
merged 1 commit into from
May 28, 2023

Conversation

sigboe
Copy link
Contributor

@sigboe sigboe commented May 22, 2023

Note this also cleans up how errors are handled and presented. For the purpouse of having a warning that just continues as well as an error that exits the script.

@sigboe
Copy link
Contributor Author

sigboe commented May 22, 2023

This PR along with #19 will allow users who already have icamerasrc-git installed to install or update the driver.

@stefanpartheym I am open to discussion how we proceed with icamerasrc-git intel has introduced a bug at this line in this file that breaks compiling. The compiler says the function is passing too many arguments, removing the second (newly added argument) fixes compiling. I have not tested if any functionality is lost by doing this. This bug was introduced in commit fe733e7 at April 3. And has issue intel/icamerasrc#32 opened at April 6. Our issue #18 was opened at April 18. Do you want us to roll our own PKGBUILD file or something? 17841ab compiles successfully and can be compiled by replacing the source array in the PKGBUILD to fetch "git+${url}.git#commit=17841ab6249aaa69bd9b3959262bf182dee74111" instead.

@stefanpartheym stefanpartheym merged commit 4ae5beb into stefanpartheym:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants