-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an addon to bring in ic-ajax & ember-data. #1047
Use an addon to bring in ic-ajax & ember-data. #1047
Conversation
is it possible for |
Not as it exists today, no. The main export for their package would have to be changed (so that when we require it and pass the Take a look at the ic-ajax main export here: https://github.com/instructure/ic-ajax/blob/master/dist/cjs/main.js#L24 |
I think that it will be common to wrap other tools with Ember CLI specific addons. |
@rjackson is there a way when developing these wrappers to either submodule it or include it as a dependency so the files are not just copied in and have to be maintained? It seems tedious to have to do that |
@jakecraige - Yep, updated and published ember-cli-ic-ajax 0.0.2 that uses npm to pull in ic-ajax (instead of vendoring). Also, take a look at ember-cli-esnext which also uses NPM (note: ember-cli-pretender addon could not do this, since pretender is not published to NPM). |
The way that the vendored asset is appended, has the pleasant benefit of allowing the user to customize their own version, by simply adding ic-ajax to |
Updated to include ember-data as an addon also. |
@rjackson this is badass. Cheers. 🍻 |
Should we have a list of known addons somewhere? Otherwise everyone is going to create their own ember-data-addon repos. Maybe even have a ember-cli org and put all the canonical repos for addons and things in it? /cc @stefanpenner @rjackson |
@tonycoco -> https://www.npmjs.org/browse/keyword/ember-cli-addon – we should likely put this on the site/readme. It might be fun to augment emberaddons.com to merely pull from NPM's API on a perf keyword basis. |
Use an addon to bring in ic-ajax & ember-data.
@rjackson im seeing this: npm WARN package.json ember-cli-ic-ajax@0.1.0 No repository field. Not sure I understand benefit of using npm over bower for all of this |
Uses https://github.com/rjackson/ember-cli-ic-ajax to provide ic-ajax, and https://github.com/twokul/ember-cli-ember-data to provide embe-data as addons.
There are at least a couple of benefits here:
npm install --save ember-cli-ic-ajax
).$.ajax
is not used (as it is not test friendly).