Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember build --watch exits immediately #1197

Closed
ghost opened this issue Jun 29, 2014 · 5 comments · Fixed by #1198
Closed

ember build --watch exits immediately #1197

ghost opened this issue Jun 29, 2014 · 5 comments · Fixed by #1198

Comments

@ghost
Copy link

ghost commented Jun 29, 2014

When running ember build --watch, the process exits immediately with an exit code of 0.

@rjackson confirmed this on master as of 876be99.

$ ember build --watch
version: 0.0.37
Buildingapp.import(vendor/ember-data/ember-data.js) - Passing modules object is deprecated. Please pass an option object with modules as export key (see http://git.io/H1GsPw for more info).
Building...

Build successful - 1014ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (stylesAndVendor)   | 173ms
TreeMerger (appAndDependencies) | 135ms
SassCompiler                   | 110ms
StaticCompiler                 | 108ms
TreeMerger (vendor)            | 94ms
TreeMerger                     | 93ms
$ echo $?
0
@stefanpenner
Copy link
Contributor

https://github.com/stefanpenner/ember-cli/blob/master/lib/tasks/build-watch.js#L17-L22
needs

  return new Watcher({
      ui: this.ui,
      builder: new Builder({outputPath: options.outputPath}),
      analytics: this.analytics,
      options: options
    }).then(function() {
      return new Promise(function() { });  // run until failure, or signal to exit
    });

@ghost
Copy link
Author

ghost commented Jun 29, 2014

Working on a little PR to add that right now! I'm rather new to node development, could you point me in the right direction on what a good way to test this would be?

@stefanpenner
Copy link
Contributor

very similar test: 2c4d70b

@stefanpenner
Copy link
Contributor

i must sleep, will provide feedback in the AM.

@ghost
Copy link
Author

ghost commented Jun 29, 2014

Here you go!

rwjblue added a commit that referenced this issue Jun 30, 2014
Close #1197 ember build --watch should run until SIGTERM
jakecraige pushed a commit to jakecraige/ember-cli that referenced this issue Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant