Recursive addons #1509
Merged
Recursive addons #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcardarella
commented
Jul 28, 2014
bcardarella
commented
|
Looks good, but this seems to be failing. |
|
@rwjblue fixed |
|
this is awesome |
| if (name !== 'ember-cli') { | ||
| var addonPath = path.join('node_modules', name); | ||
| var addonPath = path.join(root, 'node_modules', name); |
There was a problem hiding this comment.
should we use the resolve module?
There was a problem hiding this comment.
will that work with the recursion?
|
@rwjblue @stefanpenner is this OK? |
|
Needs a rebase. |
|
@rwjblue rebased |
|
Not sure whether that's a bug or I'm doing sth. wrong but with this addon package.json the |
|
@marcoow - It definitely works in general. Take a look at ember-admin, it includes a couple addons and works properly. Can you open another issue so we can track this independently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.