Cleaned up blueprint.js #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
crismali
commented
Apr 30, 2014
crismali
commented
- removed unnecessary assignment
- removed unnecessary writefile function that just swapped arguments
- made double iteration in processFiles method a simple reduce
|
doesn't merge cleanly, mind rebasing? |
| @@ -114,6 +109,13 @@ function markIdenticalToBeSkipped(info) { | |||
| } | |||
| } | |||
|
|
|||
| function isNeedingConfirmation(collection, info) { | |||
There was a problem hiding this comment.
the naming is strange, as the function also has side effects.
I think @twokul's suggestion might make more sense.
There was a problem hiding this comment.
Agreed. Actually the old .filter() -> .map() way wasn't that bad.
|
@crismali - Can you squash the commits? |
|
@rjackson sure thing |
* removed unnecessary assignment * removed unnecessary writefile function that just swapped arguments * made double iteration in processFiles method a simple reduce * update changelog to reflect changes
| @@ -114,6 +108,13 @@ function markIdenticalToBeSkipped(info) { | |||
| } | |||
| } | |||
|
|
|||
| function gatherConfirmationMessages(collection, info) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.