Remove global test helpers. #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ | |||
| * [ENHANCEMENT] Files added by ember-cli should not needed to be specified in `Brocfile.js`. [#534](https://github.com/stefanpenner/ember-cli/pull/534) | |||
| * [ENHANCEMENT] Ensure minified output is using `compress` and `mangle` options with `uglify-js`. [#564](https://github.com/stefanpenner/ember-cli/pull/564) | |||
| * [BUGFIX] Update to Broccoli 0.10.0. This should resolve the primary issue `ember-cli` has on `Windows`. [#578](https://github.com/stefanpenner/ember-cli/pull/578) | |||
| * [ENHANCEMENT] Remove global defined helpers related with in favor of exporting them from `ember-qunit` and `ember-test-helpers`. [#579](https://github.com/stefanpenner/ember-cli/pull/579) | |||
There was a problem hiding this comment.
"related with in favor of" sounds odd. Could you reword this?
There was a problem hiding this comment.
@rjackson this is a typo, I thing I was going to write something else.
|
Does this need to wait until emberjs/ember-qunit#46 is merged and published? |
|
I'll fix the wording.
I'll also try to expand on the idea behind "ember-test-helpers". On Sat, May 3, 2014 at 1:05 PM, Robert Jackson notifications@github.com
|
|
@rjackson fixed typo, need to rebase. |
|
@rjackson @stefanpenner per comment on emberjs/ember-qunit#46, this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove in favor of using http://api.qunitjs.com/equal/ http://api.qunitjs.com/strictEqual/. I started https://github.com/abuiles/ember-test-helpers to maintain helpers which are not attached to any testing framework and can be used across different projects.