Upgrading to 2.12.0 and using factoryFor over _lookupFactory #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoov
commented
Mar 29, 2017
| @@ -63,22 +63,24 @@ export default function stateFor(stateName, propertyName) { | |||
| */ | |||
| function createStateFor(context, stateName, owner) { | |||
There was a problem hiding this comment.
This file is the only one that is related to #67 changes
|
@thoov I'm interesting in getting this pull request completed. May I be of assistance? |
|
@jherdman I fixed the issue (I forgot to add back the getowner polyfil). I will release a new version shortly and can you verify in your app that everything looks good? |
|
@jherdman I just published v3.4.0 which contains this fix |
|
@thoov: Thanks for fixing this! I've tested v3.4.0 in my app and everything is working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67