Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCloud China Support #286

Closed
3 tasks done
Sowevo opened this issue Jul 7, 2023 · 7 comments
Closed
3 tasks done

iCloud China Support #286

Sowevo opened this issue Jul 7, 2023 · 7 comments
Labels
class(feature) Indicates work related to a new feature status(previewed) This issue or pull request should be fixed in a released beta version status(released) This issue or pull request was released to production

Comments

@Sowevo
Copy link

Sowevo commented Jul 7, 2023

Checklist before opening an issue

Describe the bug

hello, I'm from China,
Using iCloud in China will have another domain name https://www.icloud.com.cn
If you use https://www.icloud.com directly, a 302 error will occur

I try to directly modify the domain name in the source code constants.ts, it can work normally after modification

export const DEFAULT_HEADER = {
'User-Agent': USER_AGENT,
"Accept": `application/json`,
'Content-Type': `application/json`,
"Origin": `https://www.icloud.com`,
};

Error code

Share the Error Code generated upon the crash

Experienced fatal error at 2023/7/8 04:15:47: APP_SYNC (FATAL): Sync failed caused by AUTH_FAILED (FATAL): iCloud Authentication failed caused by AUTH_ACCOUNT_SETUP (FATAL): Unable to setup iCloud Account caused by Request failed with status code 302 (Error Code: 9d68a789-8bfb-40cf-982a-5032f67b4a9c) 

Logs

Please paste the log file (preferably with LOG_LEVEL=debug), located in .icloud-photos-sync.log, stored in the DATA_DIR.


Operating environment

  • OS: [e.g. Debian 10]
  • Version: [e.g. 1.0.0]
  • Execution environment: [e.g. docker]
@Sowevo
Copy link
Author

Sowevo commented Jul 7, 2023

Maybe add an option to modify this parameter

@steilerDev steilerDev added status(investigating) Currently looking for the root cause of the issue class(feature) Indicates work related to a new feature status(help needed) Help from other people is necessary to resolve this issue and removed status(investigating) Currently looking for the root cause of the issue labels Jul 8, 2023
@steilerDev
Copy link
Owner

As I don't have access to a Chinese iCloud account, I would need someone from China implementing this feature - no way for me to test or validate.

Happy to point in the right directions, but this would be a feature that needs to be supplied by the community with access to this.

@steilerDev steilerDev changed the title iCloud_china iCloud China Support Jul 8, 2023
@steilerDev steilerDev added status(in progress) This item is currently in scope for the next release and removed status(help needed) Help from other people is necessary to resolve this issue labels Sep 19, 2023
steilerDev pushed a commit that referenced this issue Sep 19, 2023
@github-actions
Copy link

This issue should be resolved with version v1.2.1-beta.1, please confirm.

@github-actions github-actions bot added the status(previewed) This issue or pull request should be fixed in a released beta version label Sep 23, 2023
@steilerDev steilerDev removed the status(in progress) This item is currently in scope for the next release label Sep 23, 2023
@steilerDev
Copy link
Owner

@Sowevo since I don't have an iCloud China account - could you please try and confirm by setting --region china / REGION="china"?

@Sowevo
Copy link
Author

Sowevo commented Oct 2, 2023

@Sowevo since I don't have an iCloud China account - could you please try and confirm by setting --region china / REGION="china"?

After my try, this option works fine, thank you very much

@steilerDev
Copy link
Owner

Awesome, thanks for confirming - closing this issue.

@github-actions
Copy link

This issue was resolved with version v1.3.0.

@github-actions github-actions bot added the status(released) This issue or pull request was released to production label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class(feature) Indicates work related to a new feature status(previewed) This issue or pull request should be fixed in a released beta version status(released) This issue or pull request was released to production
Projects
None yet
Development

No branches or pull requests

2 participants