Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseBackend.GetLatestLedgerSequence can crash with "index out of range" error #1888

Closed
bartekn opened this issue Oct 30, 2019 · 1 comment
Closed

DatabaseBackend.GetLatestLedgerSequence can crash with "index out of range" error #1888

bartekn opened this issue Oct 30, 2019 · 1 comment
Assignees
@tamirms
Labels
ingest New ingestion system
Milestone
Horizon 0.24.0

Comments

@bartekn
Copy link
Contributor

bartekn commented Oct 30, 2019 •
edited
Loading

If SelectRaw in DatabaseBackend.GetLatestLedgerSequence returns no rows it crashes with:

runtime error: index out of range [0] with length 0

Check why SelectRaw doesn't return ErrNoRows in such case.
@bartekn bartekn added the ingest New ingestion system label Oct 30, 2019
@ire-and-curses ire-and-curses added this to the Horizon 0.24.0 milestone Nov 12, 2019
@tamirms tamirms self-assigned this Nov 12, 2019
@tamirms tamirms mentioned this issue Nov 13, 2019
Merged
6 tasks
@tamirms
Copy link
Contributor

tamirms commented Nov 14, 2019

fixed in #1914

@tamirms tamirms closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamirms tamirms

Labels
ingest New ingestion system
Projects
None yet
Milestone
Horizon 0.24.0
Development

No branches or pull requests
3 participants
@bartekn @tamirms @ire-and-curses