Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get expiration information #153

Closed
Shaptic opened this issue Oct 2, 2023 · 0 comments · Fixed by #161
Closed

Add ability to get expiration information #153

Shaptic opened this issue Oct 2, 2023 · 0 comments · Fixed by #161

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Oct 2, 2023

Is your feature request related to a problem? Please describe.
There's no obvious way to get the expiration ledger anymore.

Describe the solution you'd like
Server.getLedgerEntries et al. should allow a fetchExpiration parameter that will automatically include a fetch for the corresponding expiration ledger entry.

Describe alternatives you've considered
You can do this manually, but you need to know oddly-specific internals about Stellar to achieve it.

This could be done on the RPC side, but it may take longer and this can be a stop-gap.

Additional context
Workaround explanation.
Discord context.

@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 2, 2023
@Shaptic Shaptic self-assigned this Oct 2, 2023
@sreuland sreuland assigned sreuland and unassigned Shaptic Oct 6, 2023
@Shaptic Shaptic mentioned this issue Oct 9, 2023
3 tasks
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 10, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 10, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 10, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 10, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 10, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 11, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 11, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 11, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 11, 2023
sreuland added a commit to sreuland/js-soroban-client that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants