Set name in custom errors #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the user needs to be able to test if an error is a
NotFoundError, ... or whatever.Keep in mind that in JavaScript/TypeScript you cannot really use
instanceoffor that, at least not across packages. There is always a chance that there are multiple versions of the package installed somewhere in the dependency tree and testing an error thrown by stellar-sdk in version A withinstanceofagainst a class imported from stellar-sdk version B will returnfalseeven though it is such an error, but instantiated by the other version of the same package.Update: You cannot use
instanceof, anyway, as the constructors explicitly overwrite the error's prototype.