-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Horizon API fields to reflect the coming post-AMM API #702
Conversation
@@ -72,6 +72,7 @@ export namespace Horizon { | |||
is_authorized: boolean; | |||
is_authorized_to_maintain_liabilities: boolean; | |||
is_clawback_enabled: boolean; | |||
sponsor?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the important change, addressing this comment.
@@ -308,7 +308,6 @@ export namespace ServerApi { | |||
id: string; | |||
paging_token: string; | |||
ledger_close_time: string; | |||
offer_id: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Use stellar-base 6.0.1 from the npm registry. * Correctly process transaction response for offers based on XDR changes (#681) * Adds a basic call builder for the `/liquidity_pools` endpoint. (#682) * Add call builder for liquidity pools, w/ filters by reserve asset * Update TradesCallBuilder to accept the trade_type filter and support Liquidity Pool trades (#685) * [CD/CI] Add GitHub Actions to run tests on PRs (#686) * Support filtering accounts participating in a given LP and update accounts balance response (#688) * Allow querying a single liquidity pool by its specific ID. (#687) * Allow querying actions (ops, txs, fx) related to a specific liquidity pool. (#689) * Add new effect types (#690) * Refactors call builders to simplify referencing 'neighbor' endpoints (#691) * Update with CAP-38 operations (#692) * Simplifies an expression to be more readable (#695) * Updates the CHANGELOG to be more uniform and specific. (#694) * Fix how the ?reserves filter works on the /accounts endpoint (#698) * Update more call builders to use the new helper API. (#699) * Add integration tests against the real mock API server (#697) * Prepares the v9.0.0 branch for merging into master (#701) * Update Horizon API fields to reflect the coming post-AMM API (#702) Co-authored-by: Marcelo Salloum dos Santos <marcelo@stellar.org> Co-authored-by: George <Shaptic@users.noreply.github.com> Co-authored-by: George Kudrayvtsev <george@stellar.org>
API field changes:
sponsor?
added to liquidity pool balancesoffer_id
dropped from trades (deprecated by Horizon)It also refactors
forLedger
methods to avoid the type check, since bothstring
andnumber
can betoString()
'd. I know these should be separate PRs but I think it really doesn't matter here.