Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepares the repository for a beta release #701

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Sep 2, 2021

Updates our CI/CD to do a beta release in preparation for v9.0.0-beta.0.

I also think we shouldn't do a version bump as part of merging #693. I prefer a safer approach where the final "release commit" is a small delta that only changes the JSON and CHANGELOG (see e.g. #670).

Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've left one comment about the npm version number ⬇️

@@ -1,6 +1,6 @@
{
"name": "stellar-sdk",
"version": "9.0.0",
"version": "8.2.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version is already 8.2.5:

"version": "8.2.5",

Shouldn't we use 8.2.6 here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think npm lets you override a version so we should always increment versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional; I'm restoring the version that's in master so it doesn't change when we merge #693. In other words, merging #693 should not release to npm yet.

@Shaptic Shaptic merged commit c6e36c9 into v9.0.0 Sep 2, 2021
@Shaptic Shaptic deleted the v9-preparation branch September 2, 2021 18:40
Shaptic added a commit that referenced this pull request Sep 2, 2021
* Use stellar-base 6.0.1 from the npm registry.
* Correctly process transaction response for offers based on XDR changes (#681)
* Adds a basic call builder for the `/liquidity_pools` endpoint. (#682)
* Add call builder for liquidity pools, w/ filters by reserve asset
* Update TradesCallBuilder to accept the trade_type filter and support Liquidity Pool trades (#685)
* [CD/CI] Add GitHub Actions to run tests on PRs (#686)
* Support filtering accounts participating in a given LP and update accounts balance response (#688)
* Allow querying a single liquidity pool by its specific ID. (#687)
* Allow querying actions (ops, txs, fx) related to a specific liquidity pool. (#689)
* Add new effect types (#690)
* Refactors call builders to simplify referencing 'neighbor' endpoints (#691)
* Update with CAP-38 operations (#692)
* Simplifies an expression to be more readable (#695)
* Updates the CHANGELOG to be more uniform and specific. (#694)
* Fix how the ?reserves filter works on the /accounts endpoint (#698)
* Update more call builders to use the new helper API. (#699)
* Add integration tests against the real mock API server (#697)
* Prepares the v9.0.0 branch for merging into master (#701)
* Update Horizon API fields to reflect the coming post-AMM API (#702)

Co-authored-by: Marcelo Salloum dos Santos <marcelo@stellar.org>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George Kudrayvtsev <george@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants