Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Adding liquidity pool docs #564

Merged
merged 14 commits into from
Oct 5, 2021
Merged

Adding liquidity pool docs #564

merged 14 commits into from
Oct 5, 2021

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Sep 6, 2021 •
edited

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

@paulbellamy paulbellamy marked this pull request as ready for review September 8, 2021 10:13
@paulbellamy paulbellamy changed the title [WIP] Adding liquidity pool docs Adding liquidity pool docs Sep 8, 2021
Shaptic
Shaptic reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! Left some minor notes but otherwise I think this is basically ready 💯

content/api/resources/liquiditypools/list.mdx Outdated Show resolved Hide resolved
content/api/resources/liquiditypools/operations.mdx Outdated Show resolved Hide resolved
content/api/resources/liquiditypools/operations.mdx Outdated Show resolved Hide resolved
content/api/resources/liquiditypools/operations.mdx Show resolved Hide resolved
content/api/resources/trades/list.mdx Outdated Show resolved Hide resolved
content/api/resources/trades/object.mdx Outdated Show resolved Hide resolved
content/api/resources/trades/object.mdx Outdated Show resolved Hide resolved
content/api/resources/trades/object.mdx Outdated Show resolved Hide resolved
content/docs/start/list-of-operations.mdx Outdated Show resolved Hide resolved
content/docs/start/list-of-operations.mdx Outdated Show resolved Hide resolved
@paulbellamy @Shaptic
Update content/api/resources/liquiditypools/list.mdx
7cdccaf 
Co-authored-by: George <Shaptic@users.noreply.github.com>
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

@paulbellamy @Shaptic
Update content/api/resources/liquiditypools/operations.mdx
6e33699 
Co-authored-by: George <Shaptic@users.noreply.github.com>
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

Shaptic
Shaptic approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you Paul! cc @rice2000

@Shaptic
Copy link
Contributor

Shaptic commented Sep 11, 2021

We shouldn't merge this until at least testnet goes live, right?

@rice2000
Copy link
Contributor

We shouldn't merge this until at least testnet goes live, right?

That's correct. This is great, and I think it's ready to merge, but we should wait to merge it until the testnet upgrade. Thanks for taking care of this, @paulbellamy!

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr564.previews.kube001.services.stellar-ops.com/

@rice2000
Copy link
Contributor

rice2000 commented Oct 5, 2021

Merging in advance of the testnet upgrade.

@rice2000 rice2000 merged commit 03682d4 into stellar:master Oct 5, 2021
@paulbellamy paulbellamy deleted the amm branch October 6, 2021 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amm: Update developer docs for new AMM endpoints
4 participants
@paulbellamy @stellar-jenkins @Shaptic @rice2000