-
Notifications
You must be signed in to change notification settings - Fork 133
Conversation
Preview is available here: |
Preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! Left some minor notes but otherwise I think this is basically ready 💯
Co-authored-by: George <Shaptic@users.noreply.github.com>
Preview is available here: |
Co-authored-by: George <Shaptic@users.noreply.github.com>
Preview is available here: |
Preview is available here: |
Preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you Paul! cc @rice2000
We shouldn't merge this until at least testnet goes live, right? |
That's correct. This is great, and I think it's ready to merge, but we should wait to merge it until the testnet upgrade. Thanks for taking care of this, @paulbellamy! |
Preview is available here: |
Merging in advance of the testnet upgrade. |
Fixes stellar/go#3884