Update dApp to work with the single-asset balance model. #80
Conversation
Shaptic
added
the
soroban-scrum
We have to drop sandbox mode, because we need classic Stellar operations. The sandbox RPC server (i.e. `soroban serve`) does not support anything but the Soroban-only `invokeHostFunction` operation. We'd need to simulate trustlines in the sandbox if we want this mode available to the example dApp.
| @@ -51,7 +51,7 @@ const Pledge: FunctionComponent = () => { | |||
| const tokenName = | |||
| token.name.result && convert.scvalToString(token.name.result) | |||
| const tokenSymbol = | |||
| token.symbol.result && convert.scvalToString(token.symbol.result) | |||
| token.symbol.result && convert.scvalToString(token.symbol.result)?.replace("\u0000", "") | |||
There was a problem hiding this comment.
Add a comment on why the "\u0000" thing is needed, please?
cc @sisuresh
There was a problem hiding this comment.
I'm not sure why this is necessary. It looks like the symbol is "symbol", and ScSymbol allows 10 chars, so maybe something is filling out the last four chars and this just strips that?
There was a problem hiding this comment.
The symbol is an asset4 code; those get padded with null bytes, right? I think that's why this is there, but I need to root-cause where it comes from.
| throw new Error(`Expected exactly one result, got ${response.results}.`); | ||
| } | ||
|
|
||
| return SorobanClient.xdr.ScVal.fromXDR(Buffer.from(results[0].xdr, 'base64')); |
There was a problem hiding this comment.
This function is moving to @soroban-react/contract in #79, but let's do this here first, and move it over after.
There was a problem hiding this comment.
Yes, will wait this to be finished and I'll include it.
|
The |
paulbellamy
force-pushed
the
update-token
branch
from
8077f5e
to
47c382a
Compare
Even without this, `deposit` should still fail on the `xfer_from`, so it shouldn't be an issue.
paulbellamy
force-pushed
the
update-token
branch
from
6a1a766
to
c05fddf
Compare
Shaptic
changed the title
Closes #76.